ContentSuggestions scheduler should be notified when the following events occurs: - NTP displayed (OnNTPOpened()) - Cold start (OnBrowserColdStart()) - App foregrounded (OnBrowserForegrounded())
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c48f1a300005c92a453e7864979b4780c2a9ac7 commit 4c48f1a300005c92a453e7864979b4780c2a9ac7 Author: gambard <gambard@chromium.org> Date: Mon Mar 06 17:45:40 2017 Suggested Articles can be dismissed Add the logic allowing the suggested articles to be dismissed in the UI and in the backend. BUG= 693031 , 698247 , 698685 Review-Url: https://codereview.chromium.org/2736653002 Cr-Commit-Position: refs/heads/master@{#454882} [modify] https://crrev.com/4c48f1a300005c92a453e7864979b4780c2a9ac7/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm [modify] https://crrev.com/4c48f1a300005c92a453e7864979b4780c2a9ac7/ios/chrome/browser/content_suggestions/content_suggestions_mediator.h [modify] https://crrev.com/4c48f1a300005c92a453e7864979b4780c2a9ac7/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm [modify] https://crrev.com/4c48f1a300005c92a453e7864979b4780c2a9ac7/ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h [modify] https://crrev.com/4c48f1a300005c92a453e7864979b4780c2a9ac7/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h [modify] https://crrev.com/4c48f1a300005c92a453e7864979b4780c2a9ac7/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f869693ef278a6e726f48a6d4b8501328d10bec4 commit f869693ef278a6e726f48a6d4b8501328d10bec4 Author: gambard <gambard@chromium.org> Date: Thu Jul 06 14:01:36 2017 Notify ContentSuggestions of app openings The ContentSuggestionsService scheduler needs to be notified of the application lifecycle (cold start, foregrounded...) to schedule the download of the articles. This CL adds such notifications. BUG= 698685 Change-Id: If65e15858fd05254ffd8fc8dfff514d8ae5b7e09 Reviewed-on: https://chromium-review.googlesource.com/559333 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#484574} [modify] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/BUILD.gn [modify] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/DEPS [modify] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/application_delegate/BUILD.gn [modify] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/application_delegate/app_state.mm [modify] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/main_controller.mm [modify] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/startup/BUILD.gn [add] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/startup/content_suggestions_scheduler_notifications.h [add] https://crrev.com/f869693ef278a6e726f48a6d4b8501328d10bec4/ios/chrome/app/startup/content_suggestions_scheduler_notifications.mm
Comment 1 by bugdroid1@chromium.org
, Mar 6 2017