Regression: Thumbnails are missing on back navigation for 'Bing' search engine.
Reported by
lpa...@etouch.net,
Mar 6 2017
|
|||||
Issue descriptionChrome Version: 59.0.3032.0 (Official Build) f82c6edf451db714b211a7c92b9c1ca3547ab0ec-refs/heads/master@{#454806} (32/64 Bit). OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12), Linux(14.04 LTS). Pre-condition: Thumbnails should be available on Google NTP. Steps to reproduce: 1. Launch chrome, change default search engine to 'Bing' from drop down list. 2. Open a NTP, on Bing Web page navigate to any site by clicking on thumbnail. 3. Click on 'back arrow icon' on top left to navigate back to Bing web page and observe. Actual Result: Thumbnails are missing on back navigation. Expected Result: Thumbnails should b displayed. This is regression issue broken in 'M 56' and will soon update the bisect info: Manual Bisect Info: Good Build 56.0.2899.0 Bad Build 56.0.2900.0
,
Mar 6 2017
Looking. So far, I've verified that the regression indeed happened between 56.0.2899.0 and 56.0.2900.0. I don't see how that CL would have caused it... looking further.
,
Mar 6 2017
Okay, I've found the problem: That CL removed a bunch of logging calls. None of those really matter, but one side effect of them was setting the "InstantSupport" flag for the page to true, which (via many intermediate steps) causes the MostVisited items to be sent to the renderer. Without that logging call, all this still happens, just slightly later - after the page has tried (and failed) to get the MostVisited items.
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/196a572ea1ff4a260f80bb3f96ebd4ffeaed0f71 commit 196a572ea1ff4a260f80bb3f96ebd4ffeaed0f71 Author: treib <treib@chromium.org> Date: Wed Mar 08 09:34:04 2017 Third-party NTPs: Set "instant support" flag earlier. This fixes a regression introduced in https://codereview.chromium.org/2429523002, which removed some unnecessary logging calls that turned out to have unexpected side effects. This CL is a workaround rather than a proper fix; as far as I can tell, it'll still be racy, though no worse than it was before. In fact, it's kind of incidental that this ever worked at all... BUG= 698675 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2733873002 Cr-Commit-Position: refs/heads/master@{#455416} [modify] https://crrev.com/196a572ea1ff4a260f80bb3f96ebd4ffeaed0f71/chrome/browser/resources/local_ntp/most_visited_util.js [modify] https://crrev.com/196a572ea1ff4a260f80bb3f96ebd4ffeaed0f71/chrome/common/search/ntp_logging_events.h
,
Mar 8 2017
,
Mar 17 2017
Tested the issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.3 using chrome latest Dev M59-59.0.3043.0 by following steps mentioned in the original comment. Observed that Thumbnails are displaying in bing as expected. Hence adding TE-Verified label. Please find the screen cast for reference. Thank you!
,
Aug 3 2017
Issue 235282 has been merged into this issue.
,
Oct 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53d7a2a18482458a12cf1a866d7bae0e2d4b590d commit 53d7a2a18482458a12cf1a866d7bae0e2d4b590d Author: Marc Treib <treib@chromium.org> Date: Mon Oct 02 10:25:56 2017 Instant cleanup: Remove no-longer-needed workaround This CL removes a newTabPage.logEvent call from the multi-iframe version of the NTP. This call never did any logging, it was just there to force the "instant support" state of third-party NTPs to "true". The notion of a page's "instant support" was removed long ago, so this workaround is no longer needed. Bug: 627747 , 698675 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I89c81c69c8c007a4713897b130d15dd0367fcea0 Reviewed-on: https://chromium-review.googlesource.com/692037 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#505568} [modify] https://crrev.com/53d7a2a18482458a12cf1a866d7bae0e2d4b590d/chrome/browser/resources/local_ntp/most_visited_util.js [modify] https://crrev.com/53d7a2a18482458a12cf1a866d7bae0e2d4b590d/chrome/common/search/ntp_logging_events.h
,
Oct 3 2017
Note: Retested the above issue on latest canary #63.0.3231.0 for Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12), Linux(14.04 LTS) and fix is working as intended. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rbasuvula@chromium.org
, Mar 6 2017Labels: hasbisect-per-revision
Owner: treib@chromium.org
Status: Assigned (was: Unconfirmed)