Regression:Weird flickering of cursor is seen in "www.bankofamerica.com"
Reported by
adha...@etouch.net,
Mar 6 2017
|
||||||||||
Issue descriptionChrome Version: 59.0.3032.0 (Official Build)f82c6edf451db714b211a7c92b9c1ca3547ab0ec-refs/heads/master@{#454806} 32/64-bit. OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) Test url:http://about.bankofamerica.com/en-us/index.html#fbid=6p2fH0Bwf5s What steps will reproduce the problem? (1)Launch chrome and navigate to the above url. (2)Click on the "Search bar" icon at top R.H.S of the page.(Kindly refer the video) (3)Observe. Actual:Weird flickering of cursor is seen after clicking on "Search bar" icon. Expected:Cursor should be seen properly after clicking on "Search bar" icon. This is a Regression issue broken in M-58,will soon update other info. Good build:58.0.3052.2 Bad build:58.0.3006.0
,
Mar 6 2017
Using the per-revision bisect providing the bisect results, Good build: 58.0.3005.2 (Revision: 448507). Bad build: 58.0.3006.0 (Revision: 448862). You are probably looking for a change made after 448798 (known good), but no later than 448799 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/8db16cac28a12030e03f709c266b8cef1e5b22ed..94d07a45f859a3430ea9de1ff8c2a95708cb23b1 From the CL above, assigning the issue to the concern owner @wangxianzhu : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url:https://codereview.chromium.org/2665823002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3032.0 Adding Release Block-Stable for this issue.Please remove if not the case.
,
Mar 6 2017
,
Mar 7 2017
Sorry, never mind #4 which is wrong.
,
Mar 7 2017
On multiple websites while editing text (Gmail, internal sites as well) I've been seeing the caret alternate between its last and current position. Is this behavior covered by this bug as well? Hard to tell from the screen captures above.
,
Mar 8 2017
#6 might be this bug or bug 699044 . Fix to these bugs will be uploaded soon. Need to verify if it also fixes #6.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f9cfc4753603c7b19d8ea434ddd6326d5417894 commit 0f9cfc4753603c7b19d8ea434ddd6326d5417894 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Thu Mar 09 03:47:26 2017 Fix caret paint invalidation issues - We should save CaretDisplayItemClient::m_previousLayoutBlock only if it has not been saved since the last paint invalidation, because we use it to invalidate the caret in the layout block of the previous paint invalidation. - Caret painted output can change paint offset without visual rect change. Invalidate display item client if the block is doing full paint invalidation. BUG= 699044 , 698662 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2736213002 Cr-Commit-Position: refs/heads/master@{#455657} [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual-expected.html [add] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual.html [add] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/LayoutTests/paint/invalidation/move-caret-in-container-change-paint-offset-keep-visual-expected.html [add] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/LayoutTests/paint/invalidation/move-caret-in-container-change-paint-offset-keep-visual.html [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/DragCaret.cpp [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/DragCaret.h [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/FrameCaret.cpp [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/FrameCaret.h [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/0f9cfc4753603c7b19d8ea434ddd6326d5417894/third_party/WebKit/Source/core/paint/BlockPaintInvalidator.cpp
,
Mar 9 2017
,
Mar 9 2017
Thanks for the fix , we will verify in today's canary and if all looks good, please merge to M58 once its approved.
,
Mar 10 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 10 2017
With response to Comment 10:Issue is not reproducible on latest Canary version i.e 59.0.3037.0.
,
Mar 10 2017
Issue is not reproducible on latest Canary version 59.0.3037.0 on Windows, Linux and Mac OS.
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d414296eea8296839c18ba2d4e2b703735526373 commit d414296eea8296839c18ba2d4e2b703735526373 Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Mar 10 17:05:52 2017 Fix caret paint invalidation issues - We should save CaretDisplayItemClient::m_previousLayoutBlock only if it has not been saved since the last paint invalidation, because we use it to invalidate the caret in the layout block of the previous paint invalidation. - Caret painted output can change paint offset without visual rect change. Invalidate display item client if the block is doing full paint invalidation. BUG= 699044 , 698662 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2736213002 Cr-Original-Commit-Position: refs/heads/master@{#455657} Review-Url: https://codereview.chromium.org/2745793002 Cr-Commit-Position: refs/branch-heads/3029@{#111} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [add] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual-expected.html [add] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual.html [add] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/LayoutTests/paint/invalidation/move-caret-in-container-change-paint-offset-keep-visual-expected.html [add] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/LayoutTests/paint/invalidation/move-caret-in-container-change-paint-offset-keep-visual.html [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/DragCaret.cpp [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/DragCaret.h [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/FrameCaret.cpp [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/FrameCaret.h [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/FrameSelection.cpp [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/editing/FrameSelection.h [modify] https://crrev.com/d414296eea8296839c18ba2d4e2b703735526373/third_party/WebKit/Source/core/paint/BlockPaintInvalidator.cpp
,
Mar 10 2017
,
Mar 17 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by adha...@etouch.net
, Mar 6 2017