New issue
Advanced search Search tips

Issue 698661 link

Starred by 4 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task


Sign in to add a comment

Editing Performance tracking issue.

Project Member Reported by yoichio@chromium.org, Mar 6 2017

Issue description

This is meta issue for logging to track Editing Performance.
 
Owner: yoichio@chromium.org
Status: Available (was: Untriaged)

Comment 2 by tkent@chromium.org, Mar 13 2017

Labels: -Type-Bug Type-Task
Blockedon: 705180
Blockedon: 582844
Labels: -Pri-1 Pri-2
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839

commit 9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Apr 13 21:38:05 2017

Revert "Add blink_perf.editing"

This reverts commit 0e2585ff6d2ab84636f89e40fb60b2e50263d534.

Reason for revert: failing everywhere on the perf waterfall
BUG= 711093 

Original change's description:
> Add blink_perf.editing
> 
> This was originally reviewed in:
> https://codereview.chromium.org/2729383003/
> And got LGTMs.
> 
> BUG=698661
> 
> Change-Id: Ibddce1f36e86926ae48970ced072de1821dd6ae6
> Reviewed-on: https://chromium-review.googlesource.com/451226
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#463981}

TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,nednguyen@google.com,telemetry-reviews@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=698661

Change-Id: I753b0294134a1db7dd3037c1c28c81e6daf8be09
Reviewed-on: https://chromium-review.googlesource.com/476810
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#464554}
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/tools/perf/benchmark.csv
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/tools/perf/benchmarks/blink_perf.py

Project Member

Comment 8 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45488678eba82672882ceab3033dd4578dfbb195

commit 45488678eba82672882ceab3033dd4578dfbb195
Author: yoichio <yoichio@chromium.org>
Date: Wed May 17 07:03:55 2017

Move PerformanceTests/Editing/addRange.html to DOM/

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2878333003
Cr-Commit-Position: refs/heads/master@{#472362}

[rename] https://crrev.com/45488678eba82672882ceab3033dd4578dfbb195/third_party/WebKit/PerformanceTests/DOM/addRange.html

Project Member

Comment 9 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/436a4cf74a6fa89ec5c570f43f6dd0cc04c0ea98

commit 436a4cf74a6fa89ec5c570f43f6dd0cc04c0ea98
Author: yoichio <yoichio@chromium.org>
Date: Tue May 23 05:25:45 2017

Move PerformanceTests/Editing/delete-in-password-field.html to DOM/

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2880203002
Cr-Commit-Position: refs/heads/master@{#473816}

[rename] https://crrev.com/436a4cf74a6fa89ec5c570f43f6dd0cc04c0ea98/third_party/WebKit/PerformanceTests/DOM/delete-in-password-field.html

Project Member

Comment 10 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd04968d5279e7797fe9d2a159881860c5e45985

commit cd04968d5279e7797fe9d2a159881860c5e45985
Author: yoichio <yoichio@chromium.org>
Date: Mon May 29 05:57:34 2017

Move PerformanceTests/Editing/move-down-with-hidden-elements.html to DOM/

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2898883002
Cr-Commit-Position: refs/heads/master@{#475295}

[rename] https://crrev.com/cd04968d5279e7797fe9d2a159881860c5e45985/third_party/WebKit/PerformanceTests/DOM/move-down-with-hidden-elements.html

Project Member

Comment 11 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4637d2197e8ea48a2b3825a3a5d777c87c84411

commit b4637d2197e8ea48a2b3825a3a5d777c87c84411
Author: yoichio <yoichio@chromium.org>
Date: Wed May 31 09:04:04 2017

Move PerformanceTests/Editing/move-up-with-hidden-elements.html to DOM/

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2899793003
Cr-Commit-Position: refs/heads/master@{#475852}

[rename] https://crrev.com/b4637d2197e8ea48a2b3825a3a5d777c87c84411/third_party/WebKit/PerformanceTests/DOM/move-up-with-hidden-elements.html

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c3bd11bf9c9a60812dae6f0500e421e8127023

commit d1c3bd11bf9c9a60812dae6f0500e421e8127023
Author: yoichio <yoichio@chromium.org>
Date: Mon Jun 26 07:13:27 2017

Move PerformanceTests/Editing/page-up-with-many-lines.html to DOM/

Once I shipped the CL that enabled PerformanceTests/Editing but it was
 reverted because of bot failures:
https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Instead of ship all of perf tests under Editing/ at once,
  I try to ship one by one under DOM directory.

BUG=698661

Review-Url: https://codereview.chromium.org/2940313002
Cr-Commit-Position: refs/heads/master@{#482206}

[rename] https://crrev.com/d1c3bd11bf9c9a60812dae6f0500e421e8127023/third_party/WebKit/PerformanceTests/DOM/page-up-with-many-lines.html

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d59067a883975e4f562cad213a676c7f5a45cbe

commit 8d59067a883975e4f562cad213a676c7f5a45cbe
Author: rnephew <rnephew@chromium.org>
Date: Mon Jun 26 18:39:22 2017

Revert of Move PerformanceTests/Editing/page-up-with-many-lines.html to DOM/ (patchset #1 id:1 of https://codereview.chromium.org/2940313002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=736784

Original issue's description:
> Move PerformanceTests/Editing/page-up-with-many-lines.html to DOM/
>
> Once I shipped the CL that enabled PerformanceTests/Editing but it was
>  reverted because of bot failures:
> https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839
> Instead of ship all of perf tests under Editing/ at once,
>   I try to ship one by one under DOM directory.
>
> BUG=698661
>
> Review-Url: https://codereview.chromium.org/2940313002
> Cr-Commit-Position: refs/heads/master@{#482206}
> Committed: https://chromium.googlesource.com/chromium/src/+/d1c3bd11bf9c9a60812dae6f0500e421e8127023

TBR=hayato@chromium.org,yosin@chromium.org,yoichio@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698661

Review-Url: https://codereview.chromium.org/2960703002
Cr-Commit-Position: refs/heads/master@{#482335}

[rename] https://crrev.com/8d59067a883975e4f562cad213a676c7f5a45cbe/third_party/WebKit/PerformanceTests/Editing/page-up-with-many-lines.html

Gotcha!
The test might be too slow on Android.
Labels: Pri-3
Labels: -Performance Performance-Browser
Blockedon: 799640
Owner: ----
Project Member

Comment 19 by sheriffbot@chromium.org, Jan 15

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment