New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698656 link

Starred by 2 users
Status: Fixed
Owner:
█ ichikawa@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
eugene...@chromium.org
ios-bugs@chromium.org
█ ichikawa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 700791


Sign in to add a comment

Implement Scripts injection API

Project Member Reported by ichikawa@chromium.org, Mar 6 2017 
Implement Scripts injection API.

- Define a class CWVUserContentController with a method -addUserScript.
- Add -[CWVWebViewConfiguration userContentController].

Comment 1 by pkl@chromium.org, Mar 6 2017

Cc: eugene...@chromium.org
Labels: -Restrict-View-Google
Owner: michaeldo@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by ichikawa@chromium.org, Mar 8 2017

Owner: ichikawa@chromium.org
Status: Started (was: Assigned)

Comment 3 by ichikawa@chromium.org, Mar 8 2017

Description: Show this description

Comment 4 by ichikawa@chromium.org, Mar 13 2017

Description: Show this description

Comment 5 by ichikawa@chromium.org, Mar 13 2017

Blockedon: 700791
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/303f5b11ca5701fd3410ad0c559fb6a88f832c71

commit 303f5b11ca5701fd3410ad0c559fb6a88f832c71
Author: ichikawa <ichikawa@chromium.org>
Date: Fri Mar 17 06:42:52 2017

Add a BrowserState* parameter to GetEarlyPageScript().

This is required to implement  crbug.com/698656 .

BUG= 698656 

Review-Url: https://codereview.chromium.org/2741343015
Cr-Commit-Position: refs/heads/master@{#457701}

[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/chrome/browser/web/chrome_web_client.h
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/chrome/browser/web/chrome_web_client.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/chrome/browser/web/chrome_web_client_unittest.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/chrome/browser/web/early_page_script_perftest.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/public/test/fakes/test_web_client.h
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/public/test/fakes/test_web_client.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/public/web_client.h
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/public/web_client.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/js/crw_js_window_id_manager_unittest.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/js/page_script_util.h
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/js/page_script_util.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/js/page_script_util_unittest.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/ui/wk_web_view_configuration_provider.h
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
[modify] https://crrev.com/303f5b11ca5701fd3410ad0c559fb6a88f832c71/ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762b38b0d18bf44ad5f0381583f45c2598ab470d

commit 762b38b0d18bf44ad5f0381583f45c2598ab470d
Author: ichikawa <ichikawa@chromium.org>
Date: Thu Mar 23 15:43:43 2017

Add CWVUserContentController which enables injecting JavaScripts.

BUG= 698656 

Review-Url: https://codereview.chromium.org/2764773002
Cr-Commit-Position: refs/heads/master@{#459093}

[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web/public/web_client.h
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/BUILD.gn
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/BUILD.gn
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/cwv_user_content_controller.mm
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/cwv_user_content_controller_internal.h
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/cwv_user_script.mm
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/cwv_web_view_configuration.mm
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/web_view_early_page_script_provider.h
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/web_view_early_page_script_provider.mm
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/web_view_web_client.h
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/internal/web_view_web_client.mm
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/public/BUILD.gn
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/public/cwv_user_content_controller.h
[add] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/public/cwv_user_script.h
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/762b38b0d18bf44ad5f0381583f45c2598ab470d/ios/web_view/public/cwv_web_view_configuration.h

Comment 8 by ichikawa@chromium.org, Mar 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment