New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698627 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Calendar picker doesn't appear after <datalist> popup

Project Member Reported by tkent@chromium.org, Mar 6 2017

Issue description

Chrome Version: 59 canary
OS: Windows.  Not reproducible on macOS.

What steps will reproduce the problem?
(1) Open the following URL:
  data:text/html,<input type=date list=dl1><datalist id=dl1><option>2017-03-31</option>
(2) Hover on the field, and click ▼
(3) Choose "Other..."

What is the expected result?
A datalist popup closes, then a calendar picker opens.

What happens instead?
A datalist popup closes, but a calendar picker doesn't open.


Please use labels and text to provide additional information.
This is a regression.  This doesn't happen with Google Chrome 56 stable.


 

Comment 1 by tkent@chromium.org, Mar 6 2017

Labels: -Needs-Bisect ReleaseBlock-Stable M-57
Owner: osh...@chromium.org
Status: Assigned (was: Available)
You are probably looking for a change made after 442726 (known good), but no later than 442741 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/2d8a66165955cb54927f24e7ea53591a82177a99..0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d



So, oshima-san's one?
https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d

URGENT - PTAL ASAP.

A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by Monday (03/06), 5:00 PM PST in order to make into the desktop Stable final build cut. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.

Cc: ranjitkan@chromium.org pbomm...@chromium.org durga.behera@chromium.org brajkumar@chromium.org
Cc: abodenha@chromium.org
abodenha@ is looking as oshima@ is on Vacation.
Owner: malaykeshav@chromium.org
malaykeshav@ can you look at this since oshima@ is OOO for the next week? Probably best to revert for now since it's only affecting 1.5x.
Status: Started (was: Assigned)

Comment 7 by tkent@chromium.org, Mar 7 2017

<input type=date> + <datalist> is not very popular.  So, IMO it would be ok to push M57 stable with this bug if the first stable refresh release will have a fix.  Of course the bug might break some web sites, and we'll be blamed for it in that case.

Labels: OS-Linux
Rechecked this issue on Ubuntu 14.04, Chrome OS Peppy and on Nexus 5 (With Android 7.0.99/ MRA20) using chrome version 59.0.3032.0. 

Able to reproduce the issue on Ubuntu 14.04, but unable to reproduce it on Chrome OS and Android as the Calendar is displayed when clicked on other.

Updating OS information.

Thanks.!
Thank you ranjitkan@. Pls add a test case for this if we haven't already.

malaykeshav@, is there any progress here?

Revert is in CQ and should be in any minute.
Meanwhile I wanted to point out that the erroneous patch effects all chrome running on fractional scale factors. It is a UI polish bug, so reverting it only causes a slightly bad UI. 

On the other hand the Calendar picker bug only happens in minor cases where an HTML widget is instantiated from within another HTML element to replace it(such as the select menu in this case. The calendar picker replaces the select menu).
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a

commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a
Author: malaykeshav <malaykeshav@chromium.org>
Date: Tue Mar 07 21:51:44 2017

Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ )

Reason for revert:
Breaking M57
crbug/698627

Original issue's description:
> Correctly update the popup window position
>
> It was updating the child window instead.
> This CL hooks up the bounds change to the desktop widget correctly.
>
> BUG=612270
> TEST=fixed test harness to do the correct check.
>
> Review-Url: https://codereview.chromium.org/2583873002
> Cr-Commit-Position: refs/heads/master@{#442741}
> Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d

TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=612270,  698627 

Review-Url: https://codereview.chromium.org/2728293004
Cr-Commit-Position: refs/heads/master@{#455231}

[modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/ui/aura/window.cc
[modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a/ui/views/widget/desktop_aura/desktop_screen_position_client.cc

Labels: Merge-Request-57
Tested the patch and only found bugs as expected from  (https://bugs.chromium.org/p/chromium/issues/detail?id=612270) which has been in stable since M52. 
Could not see any other unexpected regressions in form inputs due to this revert.
Tested with :
1) data:text/html,<input type=date list=dl1><datalist id=dl1><option>2017-03-31</option> 
2) http://www.roboform.com/filling-test-shopping-cart (similar to https://bugs.chromium.org/p/chromium/issues/detail?id=612270#c20)
3) Form inputs on https://www.w3schools.com/html/html_forms.asp
4) HTML5 input from http://www.456bereastreet.com/lab/html5-input-types/

All form inputs worked as intended with the expected UI glitch from the revert.
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Only 6 days from stable, we might already have a stable candidate build
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on comment #12 and #13. Please merge ASAP. Thank you.

 ranjitkan@, pls verify this fix in on latest Canary and M57 branch once merged. Thank you.


Project Member

Comment 16 by bugdroid1@chromium.org, Mar 7 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/750f7aa5d49254312e77f3fc947acbe5d2927769

commit 750f7aa5d49254312e77f3fc947acbe5d2927769
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Mar 07 22:50:04 2017

Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ )

Reason for revert:
Breaking M57
crbug/698627

Original issue's description:
> Correctly update the popup window position
>
> It was updating the child window instead.
> This CL hooks up the bounds change to the desktop widget correctly.
>
> BUG=612270
> TEST=fixed test harness to do the correct check.
>
> Review-Url: https://codereview.chromium.org/2583873002
> Cr-Commit-Position: refs/heads/master@{#442741}
> Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d

TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org
BUG=612270,  698627 

Review-Url: https://codereview.chromium.org/2728293004
Cr-Commit-Position: refs/heads/master@{#455231}
(cherry picked from commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a)

Review-Url: https://codereview.chromium.org/2732383002 .
Cr-Commit-Position: refs/branch-heads/2987@{#791}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/ui/aura/window.cc
[modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/750f7aa5d49254312e77f3fc947acbe5d2927769/ui/views/widget/desktop_aura/desktop_screen_position_client.cc

Labels: Merge-Request-58
Labels: TE-Verified-57.0.2987.96 TE-Verified-M57
Rechecked this on chrome version 57.0.2987.96 on Windows 10 and Ubuntu 14.04, fix is working as intended. Date picker is displayed when clicked on "other" from pull down menu.

But at the same time verified on build 59.0.3035.0 and observed that on clicking "▼" nothing happens, even the pull down menu is also not displayed. 

@malaykeshav: Request you to please take a look into it.

Adding TE-Verified for M57.
> But at the same time verified on build 59.0.3035.0 and observed that on clicking "▼" nothing happens, even the pull down menu is also not displayed. 

Looks this is a separated issue.  It's reproducible on Mac too.  I filed  Issue 699585 .

Project Member

Comment 20 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Merge-Review-58
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-58 Merge-Approved-58
Approving merge to M58 branch 3029. Please merge ASAP. Thank you.
Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!

Project Member

Comment 23 by sheriffbot@chromium.org, Mar 13 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 13 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3

commit a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Mar 13 18:55:57 2017

Revert of Correctly update the popup window position (patchset #6 id:160001 of https://codereview.chromium.org/2583873002/ )

Reason for revert:
Breaking M57
crbug/698627

Original issue's description:
> Correctly update the popup window position
>
> It was updating the child window instead.
> This CL hooks up the bounds change to the desktop widget correctly.
>
> BUG=612270
> TEST=fixed test harness to do the correct check.
>
> Review-Url: https://codereview.chromium.org/2583873002
> Cr-Commit-Position: refs/heads/master@{#442741}
> Committed: https://chromium.googlesource.com/chromium/src/+/0aafa24f1ad6b4331bdb65db12ffc1842ba69b1d

TBR=sadrul@chromium.org,bsep@chromium.org,oshima@chromium.org
BUG=612270,  698627 

Review-Url: https://codereview.chromium.org/2728293004
Cr-Commit-Position: refs/heads/master@{#455231}
(cherry picked from commit 2ba9b1f20d4f158b5cdeb359d9ab7d836e09858a)

Review-Url: https://codereview.chromium.org/2747723004 .
Cr-Commit-Position: refs/branch-heads/3029@{#159}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/ui/aura/window.cc
[modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/a2b327d0b8e2935ba42f8f4b084c4afccfc6cbf3/ui/views/widget/desktop_aura/desktop_screen_position_client.cc

Status: Fixed (was: Started)

Sign in to add a comment