PerformanceTests/Editing/delete-in-password-field.html regressed in M58 |
|||
Issue descriptionPerformanceTest/Editing/password-delete-performance.html[1] in M58 compared to M56. # 56.0.2924.87 (Official Build) (64-bit) avg 30.719000000000015 ms median 30.617500000000007 ms stdev 1.5581978456909256 ms # 58.0.3024.0 (Official Build) canary (64-bit) avg 944.1679999999999 ms median 944.2900000000004 ms stdev 5.375929882845524 ms [1] crrev.com/2730433004: Convert layout test password-delete-performance.html to performance test
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/807219a299ce1f745a2520a105ff5b2875fc497a commit 807219a299ce1f745a2520a105ff5b2875fc497a Author: yoichio <yoichio@chromium.org> Date: Thu Mar 16 05:10:47 2017 Revive layout test unintentionally removed. We should have removed editing/deleting/password-delete-performance.html not password-delete-contents.html at https://codereview.chromium.org/2730433004/ BUG= 698626 Review-Url: https://codereview.chromium.org/2753743004 Cr-Commit-Position: refs/heads/master@{#457355} [add] https://crrev.com/807219a299ce1f745a2520a105ff5b2875fc497a/third_party/WebKit/LayoutTests/editing/deleting/password-delete-contents-expected.txt [add] https://crrev.com/807219a299ce1f745a2520a105ff5b2875fc497a/third_party/WebKit/LayoutTests/editing/deleting/password-delete-contents.html [delete] https://crrev.com/a91e5309d953abb795f3c10f10609fec72a6bbfa/third_party/WebKit/LayoutTests/editing/deleting/password-delete-performance-expected.txt [delete] https://crrev.com/a91e5309d953abb795f3c10f10609fec72a6bbfa/third_party/WebKit/LayoutTests/editing/deleting/password-delete-performance.html
,
Mar 16 2017
,
Mar 16 2017
Version 59.0.3042.4 (Official Build) canary (64-bit): avg 37.323499999999996 ms median 35.97749999999991 ms stdev 4.8457290201622 ms It seems regression is gone but we still need to improve performance.
,
Mar 16 2017
Oh, it seems
document.execCommand('delete') on long password field now takes
0.3 ms avg because that test iterates 100 times per run.
I think this is acceptable in terms of user typing response.
|
|||
►
Sign in to add a comment |
|||
Comment 1 by yoichio@chromium.org
, Mar 6 2017