New issue
Advanced search Search tips

Issue 698624 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mediaview: Files app UI freezes if the user selects media view soon after login

Project Member Reported by nya@chromium.org, Mar 6 2017

Issue description

Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Make sure the user is opted into ARC++
(2) Login
(3) Open Files app
(4) Select "Images" from the left pane

What is the expected result?
Progress spinner rotates until ARC++ finishes boot

What happens instead?
UI freezes until ARC++ finishes boot

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f89cb4d2e652514501cd26bcf7fd75f1fda73f8

commit 3f89cb4d2e652514501cd26bcf7fd75f1fda73f8
Author: nya <nya@chromium.org>
Date: Wed Mar 15 02:00:45 2017

mediaview: Hack to avoid Files app to freeze soon after login.

Files app freezes until storage::WatcherManager::AddWatcher() finishes.
To avoid this issue, add a hack to ArcDocumentsProviderRoot so that
AddWatcher() pretends to finish immediately.

Ideally this issue should be fixed in Files app. However its current
design assumes operations on changing the current working directory
are serialized. Therefore this change tries to workaround the issue in
a quick way.

BUG= chromium:698624 
TEST=Files app does not freeze soon after login.
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2726373002
Cr-Commit-Position: refs/heads/master@{#456945}

[modify] https://crrev.com/3f89cb4d2e652514501cd26bcf7fd75f1fda73f8/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc
[modify] https://crrev.com/3f89cb4d2e652514501cd26bcf7fd75f1fda73f8/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h
[modify] https://crrev.com/3f89cb4d2e652514501cd26bcf7fd75f1fda73f8/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc

Comment 2 by nya@chromium.org, Mar 15 2017

Labels: Merge-Request-58
Status: Fixed (was: Started)
This is a follow-up of  Issue 684233 .
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 16 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1b243d17654d56433da28ad4d4e8865f7a3046

commit 7f1b243d17654d56433da28ad4d4e8865f7a3046
Author: Shuhei Takahashi <nya@chromium.org>
Date: Thu Mar 16 06:07:01 2017

mediaview: Hack to avoid Files app to freeze soon after login.

Files app freezes until storage::WatcherManager::AddWatcher() finishes.
To avoid this issue, add a hack to ArcDocumentsProviderRoot so that
AddWatcher() pretends to finish immediately.

Ideally this issue should be fixed in Files app. However its current
design assumes operations on changing the current working directory
are serialized. Therefore this change tries to workaround the issue in
a quick way.

BUG= chromium:698624 
TEST=Files app does not freeze soon after login.
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2726373002
Cr-Commit-Position: refs/heads/master@{#456945}
(cherry picked from commit 3f89cb4d2e652514501cd26bcf7fd75f1fda73f8)

Review-Url: https://codereview.chromium.org/2753743005 .
Cr-Commit-Position: refs/branch-heads/3029@{#227}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/7f1b243d17654d56433da28ad4d4e8865f7a3046/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc
[modify] https://crrev.com/7f1b243d17654d56433da28ad4d4e8865f7a3046/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.h
[modify] https://crrev.com/7f1b243d17654d56433da28ad4d4e8865f7a3046/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc

Status: Verified (was: Fixed)
59.0.3051.3/9404.0.0

Sign in to add a comment