New issue
Advanced search Search tips

Issue 698610 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DOMStorage might be leaking between tests

Project Member Reported by dcheng@chromium.org, Mar 5 2017

Issue description

The expected results on https://codereview.chromium.org/2706923002/#ps60001 seem to have leftover properties from other tests.

For example, in https://storage.googleapis.com/chromium-layout-test-archives/mac10_9_blink_rel/2078/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-actual.txt:

FAIL window.cached_sessionStorage.useZoomForDsfEnabled should be . Threw exception SecurityError: Failed to read the 'useZoomForDsfEnabled' property from 'Storage': access is denied for this document.

This property appears to only be set by https://cs.chromium.org/search/?q=case:yes+useZoomForDsfEnabled+package:%5Echromium$&type=cs, which is completely unrelated.
 
My proposal to resolve this:
- Move local storage namespace factory getter to WebView
- Update WebViewTestProxy to hand out shim WebStorageAreas to Blink, and keep track of the ones handed out
- Explicitly clear in TestRunner::Reset()

Sign in to add a comment