Fade/elide omnibox text
Reported by
5silentr...@gmail.com,
Mar 5 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Open any website 2. Reduce window size so that part of the text does not fit in the Omnibox What is the expected behavior? The part of the text, which does not fit entirely in the omnibox, should contain an ellipsis in the end. Like in Chrome for macOS: http://jpegshare.net/a8/e2/a8e2de3639ce4f8d82842b5ecc7cc4e8.png.html What went wrong? The part of text that does not fit entirely, just cut off in the end: http://jpegshare.net/02/20/022038ef17227f5f474988348e485903.png.html Did this work before? N/A Chrome version: 56.0.2924.87 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 24.0 r0 Sometimes it is not clear where the end of the URL
,
Mar 6 2017
Able to reproduce this issue on Win-10 and Ubuntu 14.04 using chrome reported version #56.0.2924.87 and latest canary #59.0.3030.0. This is a non-regression issue as it is observed from M30 old builds. Hence, marking it as untriaged to get more inputs from dev team. Thanks...!!
,
Mar 6 2017
I'm sure there's already a bug asking for this but I can't find it.
,
Mar 6 2017
,
Apr 16 2017
,
Apr 16 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74e44d1e750a7780d268d7713c0e07a6b349e795 commit 74e44d1e750a7780d268d7713c0e07a6b349e795 Author: simonhong <simonhong@chromium.org> Date: Tue Apr 18 21:25:59 2017 [Omnibox] Elide omnibox text Elide omnibox text when omnibox doesn't get focused. This cl has two part of changes. One part is OmniboxViewViews change. In this, elide behavior is changed based on focus state. The other is RenderText change. When display text attribute is changed, RenderText::lines_ should be cleared. BUG= 698598 TEST=interactive_ui_tests --gtest_filter=OmniboxViewViewsTest.TextElideStatus, gfx_unittests --gtest_filter=RenderText*Test.LinesInvalidationOnElideBehaviorChange Review-Url: https://codereview.chromium.org/2817403002 Cr-Commit-Position: refs/heads/master@{#465378} [modify] https://crrev.com/74e44d1e750a7780d268d7713c0e07a6b349e795/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/74e44d1e750a7780d268d7713c0e07a6b349e795/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc [modify] https://crrev.com/74e44d1e750a7780d268d7713c0e07a6b349e795/ui/gfx/render_text_harfbuzz.cc [modify] https://crrev.com/74e44d1e750a7780d268d7713c0e07a6b349e795/ui/gfx/render_text_unittest.cc
,
Apr 18 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, Mar 6 2017