New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[preload] Split `media` `as` value into `video`, `audio` and `track`

Project Member Reported by y...@yoav.ws, Mar 4 2017

Issue description

Chrome Version: M58
OS: All

Currently, with `media` destination, we cannot perform type specific mime type checks for track preloads. We need to be able to tell track apart from video and audio.
Spec change at https://github.com/whatwg/fetch/pull/437

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/543995a7a4c88dd03ba1e669193f0ce4796b7964

commit 543995a7a4c88dd03ba1e669193f0ce4796b7964
Author: yoav <yoav@yoav.ws>
Date: Thu Mar 09 13:13:04 2017

[preload] Split up media into video, audio and track

Align implementation with spec change https://github.com/whatwg/fetch/pull/437

PSA at https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BN6tqGLBmuI

BUG= 698521 

Review-Url: https://codereview.chromium.org/2732853003
Cr-Commit-Position: refs/heads/master@{#455723}

[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/download-resources.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/onerror-event.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/onload-event.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/preload-csp.sub.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/preload-default-csp.sub.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/preload-with-type.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/external/wpt/preload/single-download-preload.html
[add] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-media-as-value-expected.txt
[add] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/LayoutTests/fast/dom/HTMLLinkElement/link-preload-media-as-value.html
[delete] https://crrev.com/0e3dd8a2fa4956c145952fccdbf33383984419c2/third_party/WebKit/LayoutTests/http/tests/preload/download_resources.html
[delete] https://crrev.com/0e3dd8a2fa4956c145952fccdbf33383984419c2/third_party/WebKit/LayoutTests/http/tests/preload/onload_event.html
[delete] https://crrev.com/0e3dd8a2fa4956c145952fccdbf33383984419c2/third_party/WebKit/LayoutTests/http/tests/preload/preload_with_type.html
[delete] https://crrev.com/0e3dd8a2fa4956c145952fccdbf33383984419c2/third_party/WebKit/LayoutTests/http/tests/preload/single_download_preload.html
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/Source/core/loader/LinkLoader.cpp
[modify] https://crrev.com/543995a7a4c88dd03ba1e669193f0ce4796b7964/third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp

Comment 2 by y...@yoav.ws, Mar 9 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8565f4299ea5c705a629363dd63eb0679722bbc

commit a8565f4299ea5c705a629363dd63eb0679722bbc
Author: yoav <yoav@yoav.ws>
Date: Tue Apr 11 08:41:29 2017

Remove spurious condition from LinkLoader::getResourceTypeFromAsAttribute

While splitting the "media" `as` value in https://codereview.chromium.org/2732853003/
I accidentally added a spurious condition handling "track".
This CL removes it.

BUG= 698521 

Review-Url: https://codereview.chromium.org/2776453002
Cr-Commit-Position: refs/heads/master@{#463577}

[modify] https://crrev.com/a8565f4299ea5c705a629363dd63eb0679722bbc/third_party/WebKit/Source/core/loader/LinkLoader.cpp

Sign in to add a comment