New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698492 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Segoe UI Emoji Suit (cards) glyphs clipped

Reported by james@wheare.org, Mar 4 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Example URL:
https://jsfiddle.net/25ekqprm/1/

Steps to reproduce the problem:
1. Display Emoji suit glyphs with Segoe UI Emoji font on Windows
2. Observe clipped glyphs

<span style="font-family:'Segoe UI Emoji'; font-size: 32px;">♥️♣️♠️♦️</span>

What went wrong?
Chrome doesn't draw the bounding box of suit glyphs in Segoe UI Emoji correctly.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 56.0.2924.87  Channel: stable
OS Version: 10.0
Flash Version: 

Screenshots show broken behaviour in Chrome and working behaviour in Edge.

 
suits-clipped-chrome.png
2.0 KB View Download
suits-fine-edge.png
3.1 KB View Download
Cc: hdodda@chromium.org
Labels: Needs-Feedback
Tested on windows 10 and windows 7 using chrome M56 #56.0.2924.87 and followed below steps :

1. Launched chrome and navigated to "https://jsfiddle.net/25ekqprm/1/" and didn't observe any glyphs.

Attached screenshot for reference.

@james -- Could you please check attached screenshot and confirm us if we had missed any steps in reproducing the issue and also please check in fresh chrome profile without any extensions and flags enabled .

Thanks!
698492.JPG
76.5 KB View Download

Comment 2 by james@wheare.org, Mar 6 2017

Doesn't look like you've missed any steps. Are you testing on a full version of Windows 10 or a VM? Could you check that the Segoe UI Emoji font is installed on the test system. (It won't be on Windows 7 afaik)

I'm not setup at my PC at the moment but will verify with a clean profile later on.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 6 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Blink Blink>Fonts
I tried Windows 10 as well; Chrome 58.0.3026.0 and I cannot reproduce it either.

Comment 5 by e...@chromium.org, Mar 7 2017

Cc: e...@chromium.org
Labels: Needs-Feedback
Could you please post all information from chrome://version/ to help us track this down? Thank you.

Comment 6 by james@wheare.org, Mar 7 2017

Google Inc.
Copyright 2017 Google Inc. All rights reserved.
Google Chrome	56.0.2924.87 (Official Build) (32-bit)
Revision	0e9a9a6f3676ae439b78cd9b3f62b4193c3ac7d5-refs/branch-heads/2924@{#895}
OS	Windows 
JavaScript	V8 5.6.326.50
Flash	24.0.0.221 C:\Users\James\AppData\Local\Google\Chrome\User Data\PepperFlash\24.0.0.221\pepflashplayer.dll
User Agent	Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
Command Line	"C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --flag-switches-end
Executable Path	C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
Profile Path	C:\Users\James\AppData\Local\Google\Chrome\User Data\Default
Variations	6a89113b-a7aa8ed
90757ebb-3f4a17df
3095aa95-3f4a17df
8364a5c2-ca7d8d80
7c1bc906-f55a7974
2a33b90e-e7b70917
1c752ce9-ca7d8d80
ba3f87da-b4a760c3
58aac55e-3f4a17df
9e201a2b-3f4a17df
5274eb09-3f4a17df
8ca44045-3f4a17df
93731dca-3f4a17df
9e5c75f1-c16ec2e6
6b121ae7-ca7d8d80
f79cb77b-3d47f4f4
b7786474-d93a0620
23a898eb-ca7d8d80
4ea303a6-ecbb250e
7aa46da5-669a04e0
fe9bec35-186f5907
9736de91-ca7d8d80
3326cd71-3f4a17df
69bf80fa-91c810ef
867c4c68-3f4a17df
b2f0086-93053e47
99c41f12-3f4a17df
7fc902e8-ca7d8d80
6844d8aa-669a04e0
f47ae82a-746c2ad4
3ac60855-486e2a9c
f296190c-75cb33fc
4442aae2-75cb33fc
ed1d377-e1cc0f14
75f0f0a0-d7f6b13c
e2b18481-bd104136
e7e71889-4ad60575
828a5926-ca7d8d80
Compiler	MSVC 2015 (PGO)
segoe-font.png
59.3 KB View Download
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "eae@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by james@wheare.org, Mar 7 2017

Same issue exists in Canary:


Google Chrome	58.0.3029.3 (Official Build) canary (32-bit)
Revision	1b4c762e0c55024ae67a98dccd368035485fbfe9-refs/branch-heads/3029@{#4}
OS	Windows
JavaScript	V8 5.8.283.5
Flash	24.0.0.170 C:\WINDOWS\SysWoW64\Macromed\Flash\pepflashplayer32_24_0_0_170.dll
User Agent	Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.3 Safari/537.36
Command Line	"C:\Users\James\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --flag-switches-begin --flag-switches-end
Executable Path	C:\Users\James\AppData\Local\Google\Chrome SxS\Application\chrome.exe
Profile Path	C:\Users\James\AppData\Local\Google\Chrome SxS\User Data\Default
Compiler	MSVC 2015 (PGO)

Comment 9 by james@wheare.org, Mar 7 2017

Also confirmed it happens with a fresh Guest profile with no extensions.

Comment 10 by e...@chromium.org, Mar 8 2017

Cc: wkorman@chromium.org
Walter, any idea what could case this kind of clipping? I know we had similar problems in the past when font metrics was wrong and SP was enabled but I though we had fixed all of those by now.
Cc: -wkorman@chromium.org
Owner: wkorman@chromium.org
Status: Assigned (was: Unconfirmed)
I will take a look, this must be something else. I won't be able to get to it til next week though so if someone wants to look sooner it's ok to take it from me.

Comment 12 by e...@chromium.org, Mar 8 2017

Thanks Walter. I'll be back in SF next week, perhaps it would be helpful if the two of us could look into it together.
Q for OP: Can you provide detail on how you installed the Segoe font? And, do you believe this to be Win10 specific or would you expect it to happen or have you seen it happen on Win7?

Can't repro just now with fiddle in original bug description on Win7 with 58.0.3029.19 (Official Build) dev (64-bit).

Screenshot of what I see attached.

I do have a variety of extensions installed. Win7 install is pretty bare-bones.

Computed style for the span in question shows 'Rendered Fonts' as:

Times New Roman—Local file(8 glyphs)
segoe.png
48.2 KB View Download

Comment 14 by james@wheare.org, Mar 15 2017

No, this won't repro with Windows 7 by default as the Segoe UI Emoji font was (I believe) only made available in Win8. The Segoe UI Symbol font in Win7 is not the same.

You may be able to download and install it manually but I'm not sure how, and that may not lead to a repro either.

See screenshot earlier in the thread for the install location of the font on my system: https://bugs.chromium.org/p/chromium/issues/attachment?aid=274147&inline=1

I'm pretty sure it's installed by default on Win10, and I've had other people report they see the same issue.

Comment 15 by james@wheare.org, Mar 15 2017

Note also that the screenshot in comment 1 does not show the Segoe UI Emoji font being used either: https://bugs.chromium.org/p/chromium/issues/attachment?aid=273903&inline=1

Those glyphs are coloured at least, but missing the outlines.
OK, I have a Win10 machine at home so I can take a look there later.
I am blocked on home Win10 machine due to a bug in fetch with username with space. I'll see if I can find a workaround or borrow a coworker's Win10 machine at office.
Cc: -e...@chromium.org wkorman@chromium.org
Owner: e...@chromium.org
I still don't have a working Win10 machine, passing to eae@ as I think he has one.

Comment 19 by e...@chromium.org, May 11 2017

Confirmed in 58 and 60 on Windows 10. Segoe UI Emoji is used and the glyphs are clipped.

Comment 20 by e...@chromium.org, May 30 2017

Cc: drott@chromium.org kojii@chromium.org e...@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 21 by drott@chromium.org, May 31 2017

Does not reproduce here on 58.0.3029.110 and neither on 61 Canary on Windows 10. 
james@, is this on a High DPI or a regular resolution display? 

eae@, how about in your reproduction? Which device scale factor?

Comment 22 by e...@chromium.org, May 31 2017

Repros on 2x and 1x DPI on win 8.1 and win 10 for me.

Comment 23 by drott@chromium.org, May 31 2017

eae@, what's the checksum of your SEGUIEMJ.TTF? Does it match these?

$  md5sum SEGUIEMJ.TTF 
df2c56fc75de6974150e2e0a5f01d684  SEGUIEMJ.TTF

$  shasum -a256 SEGUIEMJ.TTF 
fe6931430747f8f7927952b74caec56f864291168ae466eb6252f41da10ebcd4  SEGUIEMJ.TTF

Comment 24 by e...@chromium.org, May 31 2017

C:\Windows\Fonts>md5sum SEGUIEMJ.TTF
59093a3f2490cc4ab8e3c696aad26217 *SEGUIEMJ.TTF

C:\Windows\Fonts>shasum -a256 SEGUIEMJ.TTF
'shasum' is not recognized as an internal or external command,
operable program or batch file.

Comment 25 by james@wheare.org, May 31 2017

Repros for me still on 58.0.3029.110 at 1x DPI Win 10

$ md5sum seguiemj.ttf
9bf787e2f202563ca98d6781b5f93def *seguiemj.ttf

$ shasum -a256 seguiemj.ttf
d67717a6fe84e21bc580443add16ec920e6988ca067041d0461c641f75074a8c *seguiemj.ttf

Comment 26 by james@wheare.org, May 31 2017

I have version 1.12 of the font now, my previous screenshot in this thread showed 1.11: https://bugs.chromium.org/p/chromium/issues/detail?id=698492#c6

Comment 27 by drott@chromium.org, Jun 15 2017

Cc: bunge...@chromium.org
Ben, any ideas what could be going wrong here? 
The first thing that's wrong is our 'new bug' page needs to have explicit instructions to include the output of the 'ver' command when the OS is Windows since Windows10 is a marketing name and contains no version number. I don't see this issue currently on "Microsoft Windows [Version 10.0.10586]", but I know I don't have the same "Segoe UI Emoji" because the glyphs in the report have a black/text color border which was added later. Unfortunately I don't have a newer version of Windows installed on one of my boxes, I'll have to see about that.

Comment 29 by james@wheare.org, Jun 15 2017

I (OP) am on Microsoft Windows [Version 10.0.15063]
Cc: -bunge...@chromium.org
Components: Internals>Skia
Owner: bunge...@chromium.org
Status: Assigned (was: Available)
Can confirm this reproduces with the "Segoe UI Emoji" on 10.0.14393. It appears that when the color glyph handling was landed it was not reviewed thoroughly enough. The bounds in this case are being calculated from the base glyph instead of the color glyph. It appears that in earlier versions of the font the color glyph runs and the base glyphs were the same size. In the new font version some color glyph runs are larger than their base glyph, leading to clipping. Will need to update this to get the correct bounds.

Comment 31 by drott@chromium.org, Jun 27 2017

Thanks for the analysis, Ben.
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a3dcaaf7b7bd2b59459e568bfbc3694cafe4374

commit 1a3dcaaf7b7bd2b59459e568bfbc3694cafe4374
Author: Ben Wagner <bungeman@chromium.org>
Date: Fri Jun 15 15:47:20 2018

Add SK_IGNORE_WIN_EMOJI_FIX Skia build flag.

A fix for color emoji bounds on Windows is about to land in Skia but
will affect three layout tests. This flag will suppress the Skia change
until it is possible to rebaseline.

BUG= chromium:698492 

Change-Id: I716e47b0fba0921a8fe9779aab071000a3960d7e
Reviewed-on: https://chromium-review.googlesource.com/1102488
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567655}
[modify] https://crrev.com/1a3dcaaf7b7bd2b59459e568bfbc3694cafe4374/skia/BUILD.gn

Project Member

Comment 33 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/46f25635474e6b1e4289cf9fd5f6c3ddd3696ead

commit 46f25635474e6b1e4289cf9fd5f6c3ddd3696ead
Author: Bruce Wang <brucewang@google.com>
Date: Fri Jun 15 16:11:35 2018

Implement SkScalerContext_DW::generateColorMetrics(SkGlyph* glyph) on Windows.

Fix layout problem for color glyph.

BUG= chromium:698492 
Change-Id: Iff586332ee0d7fdbf8c6c7f340536855b753769c
Reviewed-on: https://skia-review.googlesource.com/134519
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/46f25635474e6b1e4289cf9fd5f6c3ddd3696ead/src/ports/SkScalerContext_win_dw.h
[modify] https://crrev.com/46f25635474e6b1e4289cf9fd5f6c3ddd3696ead/src/ports/SkScalerContext_win_dw.cpp

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0268b6fde5f65f8ebaf3d0ee55f08aa7908863f

commit c0268b6fde5f65f8ebaf3d0ee55f08aa7908863f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 15 18:21:07 2018

Roll src/third_party/skia d7bfcaf57c1f..5540528f81c0 (10 commits)

https://skia.googlesource.com/skia.git/+log/d7bfcaf57c1f..5540528f81c0


git log d7bfcaf57c1f..5540528f81c0 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 bungeman@google.com Revert "Reland "added 565 to 8888 conversion for gpu LCD text rendering for macOS""
2018-06-15 bungeman@google.com Reland "Remove SK_MaxSizeT, SK_M{in|ax}U{16|32}, #defines."
2018-06-15 brucewang@google.com Implement SkScalerContext_DW::generateColorMetrics(SkGlyph* glyph) on Windows.
2018-06-15 jvanverth@google.com Change scaling of antialiased perspective text in dftext to help glitches.
2018-06-15 robertphillips@google.com Revert "Move op memory storage to GrContext"
2018-06-15 timliang@google.com Reland "added 565 to 8888 conversion for gpu LCD text rendering for macOS"
2018-06-15 benjaminwagner@google.com Update kitchen to version built with Go 1.10.3.
2018-06-15 fmalita@chromium.org [skjson] Catch end-of-stream for unbalanced scopes
2018-06-15 brianosman@google.com Simplify usage of GrGLSLColorSpaceXformHelper
2018-06-15 egdaniel@google.com Don't explicitly include vulkan.h in the vulkan memory allocator.


Created with:
  gclient setdep -r src/third_party/skia@5540528f81c0

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:698492 ,chromium:836196
TBR=csmartdalton@chromium.org

Change-Id: I9bfca635a082572d5fc6931f00ba56028816f30d
Reviewed-on: https://chromium-review.googlesource.com/1102857
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567734}
[modify] https://crrev.com/c0268b6fde5f65f8ebaf3d0ee55f08aa7908863f/DEPS

Status: Fixed (was: Assigned)
Should be fixed in M69.

Comment 37 by drott@chromium.org, Jun 19 2018

Labels: M-69 Target-69

Sign in to add a comment