Feature policy gets reset on in-frame navigation |
||
Issue descriptionAn error in c/b/frame_host/navigator_impl.cc means that the browser-side copy of a policy gets reset on every navigation that *doesn't* leave the page; fragment navigations, generally. (This causes no issues currently, as the browser copy isn't being used for any decisions. However, it needs to get fixed before we do.) The condition should be fixed, and more importantly, the FP reset should be tested explicitly in unittests.
,
Mar 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f46f88a56a012c3633a76662cc2f1735c42d9174 commit f46f88a56a012c3633a76662cc2f1735c42d9174 Author: iclelland <iclelland@chromium.org> Date: Sat Mar 04 14:01:44 2017 Don't recreate feature policy on fragment navigation. This looks like just an optimization for now: the policy is currently recreated on every navigation from the parent policy and the document's own headers, and this eliminates that work when the navigation is just within the page. It will be more important soon, though, once per-frame policies are implemented. At that point, this also will prevent the policy from changing, if the embedding iframe attributes have been updated since the document became active. BUG= 698481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2707263013 Cr-Commit-Position: refs/heads/master@{#454773} [modify] https://crrev.com/f46f88a56a012c3633a76662cc2f1735c42d9174/content/browser/frame_host/navigator_impl.cc [modify] https://crrev.com/f46f88a56a012c3633a76662cc2f1735c42d9174/content/browser/frame_host/navigator_impl_unittest.cc
,
Mar 21 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted