New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698466 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 657267



Sign in to add a comment

Cocoa Page Info: "Site settings" button has extra padding.

Project Member Reported by lgar...@chromium.org, Mar 4 2017

Issue description

It needs to be 4px smaller.
 
Screen Shot 2017-03-03 at 18.34.22.png
153 KB View Download
Blocking: 657267
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7115b681d0852f64676445b13f50f026f111e71

commit d7115b681d0852f64676445b13f50f026f111e71
Author: lgarron <lgarron@chromium.org>
Date: Tue Mar 07 02:40:39 2017

Cocoa Page Info: Take built-in padding into account for "Site settings" button placement.

BUG= 698466 

Review-Url: https://codereview.chromium.org/2723233006
Cr-Commit-Position: refs/heads/master@{#455025}

[modify] https://crrev.com/d7115b681d0852f64676445b13f50f026f111e71/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Is this fixed now?
Status: Fixed (was: Started)
Yep!

Sign in to add a comment