Unify interpretation of "related" controls |
||||
Issue descriptionThe codebase has distinct concepts of "related" and "unrelated" controls, but the distinction is poorly defined. I argue that "related" controls should be things like a checkbox and that checkbox' label, or the vertical distance between two radio buttons in a group. In other words, things users would think of as one logical control. All other cases should be "unrelated". (Borderline case I don't know how to decide: an icon with a descriptive label right next to it, as in the page info dropdown.) If we make this change, I think the "related control" distance should be 8-12 DIPs (I suggest 8). It's currently 16 in the codebase. This would most obviously affect checkbox/radio-to-label distances, but it also affects how columns of items stack (the spec tends to talk about such cases in terms of the heights of whole rows, which have implicit padding internally, rather than as padding values between unpadded elements, so it's hard for me to say precisely what effect this would have). Assigning to bettes@ initially in hopes of settling on this value. Once that decision is agreed on, the rest of this bug will be about changing existing usage to comply with the above (mostly to make existing "related" usage "unrelated"), and trying to eliminate the "item label spacing" constant in favor of one of the two constants above. Tentative plan is to give this to bsep@.
,
Mar 8 2017
Allen, do you have some 8-vs.-16 DIP screenshots of various things you can attach here so Alan can see them? I could try to do some local builds to grab these if need be.
,
Aug 2 2017
The decision on related labels, for now, was to distinguish between related labels in a horizontal list such as the bookmark bar (which, in Harmony, are 8 DIP apart) and "anywhere else", where they're 16 DIP apart. There was no real objection to defining "related" and "unrelated" as proposed in comment 0, but I suggest work to standardize this be tabled until after we ship Harmony phase 1. That's because in Harmony many of the "related/unrelated" distinctions disappear (all have the same value), especially in the horizontal case. We should generally get things pretty good just via the dialog passes done in phase 1, and once we ship Harmony and rip out the old code we can decide how to deal with the remaining terminology/distinctions. Unassigning and lowering to P3.
,
Aug 2
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
Leaving available for now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by pkasting@chromium.org
, Mar 4 2017