Tapping nav buttons leaves their tooltips open, and shows the highlight gray background |
||||||
Issue descriptionChrome Version : 56.0.2924.87 OS Version: 10.0 What steps will reproduce the problem? 1. Tap a nav button (back, fwd, home, reload) 2. Wait for navigation to happen What is the expected result? No tooltip What happens instead of that? Tooltip opens and stays open forever See video: https://docs.google.com/presentation/d/14jaX3op8_a87DXyFCZrSsU7mVA-666P707yvQbQ_84Y/edit#slide=id.g1ce581d6de_0_0
,
Mar 7 2017
,
Mar 8 2017
,
Mar 8 2017
Note: issue 699668 is evidence of my conjecture in #1 being at least partially to blame for the class of "hover states and tooltips remain when using touch" issues, rather than all the blame being placed on MD ripple states in buttons: tapping on a tab will sometimes show its tooltip, but a tab is not part of the Button view hierarchy.
,
Apr 18 2017
,
Apr 19 2017
Patch is at https://codereview.chromium.org/2829653002/
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2 commit a19d2ff185b04105bf66c835f8bb84b8b5fb79b2 Author: girard <girard@chromium.org> Date: Thu Apr 20 17:22:42 2017 Removed (spurious, touch-initiated) tooltips from nav buttons Windows generates WM_MOUSEMOVE buttons at random points (to make sure that apps know where the cursor is). In some cases the cursor location was caused by a touch event - the mouse cursor jumps to the last touch location. This patch tracks the last touch location so that tooltips can ignore those extraneous mousemove's. BUG= 698435 Review-Url: https://codereview.chromium.org/2829653002 Cr-Commit-Position: refs/heads/master@{#466046} [modify] https://crrev.com/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2/ui/views/corewm/tooltip_controller.cc [modify] https://crrev.com/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2/ui/views/corewm/tooltip_controller.h [modify] https://crrev.com/a19d2ff185b04105bf66c835f8bb84b8b5fb79b2/ui/views/corewm/tooltip_controller_unittest.cc
,
Apr 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rpop@chromium.org
, Mar 4 2017