Code review comments from https://codereview.chromium.org/2675033002/diff/280001/chrome/browser/media/router/mojo/media_router.mojom Create a typemap for net::IPAddress. Use net::IPAddress instead of string for ip_address in media_router.mojom struct DialMediaSink { string ip_address; ... } struct CastMediaSink { string ip_address; ... }
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81b759bf2a2fc62238efe3f01eb5faa74f2d374 commit d81b759bf2a2fc62238efe3f01eb5faa74f2d374 Author: zhaobin <zhaobin@chromium.org> Date: Fri Mar 10 18:38:33 2017 [net] Add a typemap for net::IPAddress To resolve code review comments from https://codereview.chromium.org/2675033002/diff/280001/chrome/browser/media/router/mojo/media_router.mojom Create an ip_address.mojom to be used by media_router.mojom BUG= 698423 Review-Url: https://codereview.chromium.org/2745643002 Cr-Commit-Position: refs/heads/master@{#456115} [modify] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/BUILD.gn [modify] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/OWNERS [add] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/ip_address.mojom [add] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/ip_address.typemap [add] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/ip_address_struct_traits.cc [add] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/ip_address_struct_traits.h [modify] https://crrev.com/d81b759bf2a2fc62238efe3f01eb5faa74f2d374/net/interfaces/typemaps.gni
Comment 1 by sko...@chromium.org
, Mar 9 2017