No way to “Press TAB to search [Search engine]” via touch input |
|||
Issue description
Chrome Version : 56.0.2924.87
OS Version: 10.0
What steps will reproduce the problem?
1. Using OSK, type search engine shortcut text
2. "Press tab to search" appears
What is the expected result?
There's some way to use the custom search engine
What happens instead of that?
No way to access feature without a physical keyboard
Per hwi@:
1. Easiest fix will be making "Press [tab] to Search {Search engine}" as a touch/click target.
2. Plus, probably, conditionally change the element to [Search {Search engine name}] in a graybox like "[tab]" on the screenshot to make it look like a touch target, when the OSK is present.
Note that fix #1 is possible even if we can't query for OSK presence. If it is possible, please assign to hwi@ for a mock of fix #2.
See also: https://docs.google.com/presentation/d/14jaX3op8_a87DXyFCZrSsU7mVA-666P707yvQbQ_84Y/edit#slide=id.g1cecc3395b_0_1
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe commit ba63e101443732a1eddcc0ea63eb26cdb0ec33fe Author: estade <estade@chromium.org> Date: Thu Apr 06 01:42:25 2017 Make keyword hint view ("press tab to search foo.com") clickable. Since there is no tab button on touch devices (on screen keyboard has no tab), the view will need to be clickable. This might as well apply to all devices, physical keyboard or no. As noted on the bug, the view's appearance will also change to something that makes more sense when you don't have a tab key. BUG= 698422 Review-Url: https://codereview.chromium.org/2792103005 Cr-Commit-Position: refs/heads/master@{#462315} [modify] https://crrev.com/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe/chrome/browser/ui/views/location_bar/keyword_hint_view.cc [modify] https://crrev.com/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe/chrome/browser/ui/views/location_bar/keyword_hint_view.h [modify] https://crrev.com/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe/components/omnibox/browser/omnibox_edit_model.h [modify] https://crrev.com/ba63e101443732a1eddcc0ea63eb26cdb0ec33fe/tools/metrics/histograms/histograms.xml
,
Apr 7 2017
,
Apr 7 2017
Thanks, estade@. I'll try and get to this next week.
,
Apr 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0 commit 3578d3111a37b2ee39f306bb285a5fdc6b3e23a0 Author: estade <estade@chromium.org> Date: Sat Apr 08 01:05:26 2017 Adjust appearance of omnibox keyword hint view for on-screen keyboards. BUG= 698422 Review-Url: https://codereview.chromium.org/2803693007 Cr-Commit-Position: refs/heads/master@{#463089} [modify] https://crrev.com/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0/chrome/app/generated_resources.grd [modify] https://crrev.com/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0/chrome/browser/ui/views/location_bar/keyword_hint_view.cc [modify] https://crrev.com/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0/chrome/browser/ui/views/location_bar/keyword_hint_view.h [modify] https://crrev.com/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0/ui/keyboard/keyboard_util.cc [modify] https://crrev.com/3578d3111a37b2ee39f306bb285a5fdc6b3e23a0/ui/keyboard/keyboard_util.h
,
Apr 10 2017
fixed modulo bugs/design feedback.
,
May 1 2017
Is this on by default or behind a flag? If it's on, we need design review before it hits beta. +bettes while hwi is ooo |
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Apr 4 2017Status: Started (was: Available)