New issue
Advanced search Search tips

Issue 698410 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Mar 2017
Cc:
kkhorimoto@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

DidFinishNavigation for hash change is fired with incorrect WebState URL

Project Member Reported by eugene...@chromium.org, Mar 3 2017 
Steps to reproduce: 
1. Uncomment URL check in VerifySamePageContext
2. Run UserInitiatedHashChangeNavigation test

Observed behavior: 
Test fails, with actual URL http://localhost:8080/chromium.test/#1

Expected behavior: 
Expected WebState's last committed URL should be http://localhost:8080/chromium.test/

Comment 1 by eugene...@chromium.org, Mar 4 2017

Summary: DidFinishNavigation for hash change is fired with incorrect WebState URL (was: DidFinishNavigation for has change is fired with incorrect WebState URL)

Comment 2 by eugene...@chromium.org, Mar 4 2017

Owner: eugene...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf

commit 9b8867c5b4b08dd484fb631fadacb6d247cdc7cf
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 07 19:06:33 2017

Removed -[CRWWebDelegate webDidStartLoadingURL:updateHistory:].

This callback is replaced by WebStateObserver::DidFinishNavigation.

Call OnNavigationCommitted after |webPageChanged|, because
NavigationItem is committed inside |webPageChanged|.
UpdateHttpResponseHeaders() should still be called before
SetContentsMimeType(), so |UpdateHttpResponseHeaders| was moved
out of |OnNavigationCommitted|.

BUG= 692331 , 698410 

Review-Url: https://codereview.chromium.org/2724383003
Cr-Commit-Position: refs/heads/master@{#455167}

[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/chrome/browser/tabs/tab_unittest.mm
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/navigation/crw_session_controller.mm
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/public/web_state/ui/crw_web_delegate.h
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/web_state/navigation_callbacks_inttest.mm
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf/ios/web/web_state/web_state_impl_unittest.mm

Comment 4 by eugene...@chromium.org, Mar 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment