FileUtilTest.OpenFileNoInheritance fails on Chromecast; ccs=UNICODE invalid |
|||
Issue descriptionhttps://codereview.chromium.org/2687713003 Fails on all chromecast devices [ RUN ] FileUtilTest.OpenFileNoInheritance ../../base/files/file_util_unittest.cc:1751: Failure Expected: (nullptr) != (file), actual: 4-byte object <00-00 00-00> vs NULL Google Test trace: ../../base/files/file_util_unittest.cc:1748: r,ccs=UNICODE [ FAILED ] FileUtilTest.OpenFileNoInheritance (1 ms) Added some extra log info: INFO:file_util_posix.cc(745)] result: 0xb8f2fc60, errno: 0, filename: /tmp/.org.chromium.Chromium.SmP2Az/a_file, mode: wbe, LC_CTYPE: C INFO:file_util_posix.cc(745)] result: 0, errno: 22, filename: /tmp/.org.chromium.Chromium.SmP2Az/a_file, mode: re,ccs=UNICODE, LC_CTYPE: C Also tried a few other variations: ccs=UTF-8 passes errno: 0, filename: /tmp/.org.chromium.Chromium.K8LMEs/a_file, mode: re,ccs=UTF-8 UTF-16 and UTF-16LE both fail errno: 22, filename: /tmp/.org.chromium.Chromium.8XVvMm/a_file, mode: re,ccs=UTF-16LE errno: 22, filename: /tmp/.org.chromium.Chromium.HOb9jk/a_file, mode: re,ccs=UTF-16 Does this test need to use ccs=UNICODE, or can it be changed to use ccs=UTF-8 so it will pass on chromecast devices?
,
Mar 6 2017
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d62f880e739c41ddd24b2c5e54a9dfe05033789 commit 4d62f880e739c41ddd24b2c5e54a9dfe05033789 Author: grt <grt@chromium.org> Date: Mon Mar 06 13:25:08 2017 Use UTF-8 rather than UNICODE for the OpenFile w/ character set test. This makes the test pass on chromecast devices, which presumably don't support UNICODE. The exact value isn't important for the test. BUG= 698396 Review-Url: https://codereview.chromium.org/2731263002 Cr-Commit-Position: refs/heads/master@{#454859} [modify] https://crrev.com/4d62f880e739c41ddd24b2c5e54a9dfe05033789/base/files/file_util_unittest.cc
,
Mar 6 2017
,
Mar 6 2017
Thank you! :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by mbjorge@chromium.org
, Mar 3 2017