New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698392 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Physical Web preference renders as "On" when pref is in Default state

Project Member Reported by mattreynolds@chromium.org, Mar 3 2017

Issue description

If the Physical Web preference is in its default state and Chrome is authorized to use the user's location, the toggle on the Physical Web preference page renders in the "On" position. We'd like it to render as "Off" whenever the pref is in its Default state.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c3ae5fc7b7a3a9395b882f80661f209f3bfc4ef

commit 9c3ae5fc7b7a3a9395b882f80661f209f3bfc4ef
Author: mattreynolds <mattreynolds@chromium.org>
Date: Fri Mar 03 23:17:01 2017

Physical Web toggle should render as Off with pref in Default state

Previously, the Physical Web toggle would render in the On position if the
preference was still in the Default state and Chrome was authorized to use
Location. Now, the preference will only render as On if the preference has
been enabled.

BUG= 698392 

Review-Url: https://codereview.chromium.org/2735463002
Cr-Commit-Position: refs/heads/master@{#454705}

[modify] https://crrev.com/9c3ae5fc7b7a3a9395b882f80661f209f3bfc4ef/ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm

Labels: Merge-Request-58 Merge-Request-57
Verified that this has landed in Canary 59.0.3033.0.  We'd like to merge this to M57 and M58.
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Less than 3 days to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can this wait for M58? 
The effect of not landing in m57 is that in some cases users think PW is on when really it is not.

Real world effect will probably be limited to our power users who know about PW and explicitly go to settings page to make sure it is on, and are then surprised it isn't working.  We would need to make awkward communications about toggling off then on again to resolve.

Mildly irritating for us, but not merging into m57 is unlikely to be a big issue for majority of users.
I'm fine with waiting for M58 for this fix.
Verified on 59.0.3035.0 on iPhone 7+ iOS 10.2.1
1. Location Services is enabled.Google Search is the default search provider.Chrome is not currently in Incognito mode.
Clean Install app.Go to Menu->Settings->Search Engine->Check yahoo! .Go to Chrome://flags.Enable PW.Force quit app.Relaunch app, go to Menu-Settings->Privacy.PW is OFF.
1a.Go back to iOS settings and disable location services.Force quit app.Relaunch app, go to Menu-Settings->Privacy.PW is OFF.

5.Location Services is enabled.Chrome is authorized to use your location "While Using the App”.Google Search is the default search provider.Go to chrome://flags in incognito mode.Enable PW.Force quit app.Relaunch app, go to Menu-Settings->Privacy.PW is OFF.
Labels: -Merge-Review-57 Merge-Rejected-57
Thanks mmocny@. Based on your comment#6, I will rather have this in M58 than merging it this late in the cycle since the majority of users will not be affected.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 9 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cedf1e53b208a35c211dcf751f5272856f6f346b

commit cedf1e53b208a35c211dcf751f5272856f6f346b
Author: Michal Mocny <mmocny@chromium.org>
Date: Thu Mar 09 15:55:44 2017

Physical Web toggle should render as Off with pref in Default state

Previously, the Physical Web toggle would render in the On position if the
preference was still in the Default state and Chrome was authorized to use
Location. Now, the preference will only render as On if the preference has
been enabled.

BUG= 698392 

Review-Url: https://codereview.chromium.org/2735463002
Cr-Commit-Position: refs/heads/master@{#454705}
(cherry picked from commit 9c3ae5fc7b7a3a9395b882f80661f209f3bfc4ef)

Review-Url: https://codereview.chromium.org/2744643002 .
Cr-Commit-Position: refs/branch-heads/3029@{#84}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/cedf1e53b208a35c211dcf751f5272856f6f346b/ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 58.0.3029.18dev on iPhone 7+ iOS 10.2.1
1. Location Services is enabled.Google Search is the default search provider.Chrome is not currently in Incognito mode.
Clean Install app.Go to Menu->Settings->Search Engine->Check yahoo! .Go to Chrome://flags.Enable PW.Force quit app.Relaunch app, go to Menu-Settings->Privacy.PW is OFF.
1a.Go back to iOS settings and disable location services.Force quit app.Relaunch app, go to Menu-Settings->Privacy.PW is OFF.

5.Location Services is enabled.Chrome is authorized to use your location "While Using the App”.Google Search is the default search provider.Go to chrome://flags in incognito mode.Enable PW.Force quit app.Relaunch app, go to Menu-Settings->Privacy.PW is OFF.

Sign in to add a comment