New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698391 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 688538



Sign in to add a comment

[Merge request][M58] Accommodating UI review feedback for last used experiment

Project Member Reported by jiahuiguo@google.com, Mar 3 2017

Issue description

Changing Autofill credit card suggestions popup to show last used date UI to conform to UI review feedback.

chrome-ui-review thread: 
https://groups.google.com/a/google.com/d/msg/chrome-ui-review/Ds7Rr8NvNl8/SHG_dYXPAAAJ

implementation review deck: 
https://docs.google.com/presentation/d/10ulaOLTXwI_Fks5ty5SaotxosCFRtrkCSUZjq-PI87A/edit#slide=id.g1cbea1aaa5_0_0

 
Labels: -M58 Merge-Request-58
Project Member

Comment 2 by sheriffbot@chromium.org, Mar 4 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 8 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30

commit e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30
Author: jiahuiguo <jiahuiguo@google.com>
Date: Wed Mar 08 20:41:01 2017

[Merge M58] Adopt UI review feedback

Get rid of colon in Autofill credit card popup suggestions last used
date UI string.

BUG= 698391 
TEST=CreditCardTest.GetLastUsedDateForDisplay(components_unittests)

Review-Url: https://codereview.chromium.org/2730133003
Cr-Commit-Position: refs/heads/master@{#455533}

[modify] https://crrev.com/e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30/components/autofill_strings.grdp

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc01afb620dc3f47942ca79148371664a1afa604

commit cc01afb620dc3f47942ca79148371664a1afa604
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Mar 08 22:24:22 2017

[Merge M58] Adopt UI review feedback

Get rid of colon in Autofill credit card popup suggestions last used
date UI string.

BUG= 698391 
TEST=CreditCardTest.GetLastUsedDateForDisplay(components_unittests)

Review-Url: https://codereview.chromium.org/2730133003
Cr-Commit-Position: refs/heads/master@{#455533}
(cherry picked from commit e5e6dd9b559d0787d8ed20f8c3c45fd4dcbb5f30)

Review-Url: https://codereview.chromium.org/2739743003 .
Cr-Commit-Position: refs/branch-heads/3029@{#70}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/cc01afb620dc3f47942ca79148371664a1afa604/components/autofill/core/browser/credit_card.cc
[modify] https://crrev.com/cc01afb620dc3f47942ca79148371664a1afa604/components/autofill/core/browser/credit_card_unittest.cc
[modify] https://crrev.com/cc01afb620dc3f47942ca79148371664a1afa604/components/autofill_strings.grdp

Comment 6 by ma...@chromium.org, Mar 8 2017

Status: Fixed (was: Assigned)

Sign in to add a comment