New issue
Advanced search Search tips

Issue 698376 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

INSERTION_HANDLE_MOVED being triggered incorrectly

Project Member Reported by amaralp@chromium.org, Mar 3 2017 
Chrome Version: M58
OS: Android/ChromeOS/Windows/Linux

What steps will reproduce the problem?
(1) Tap non-empty editable text box
(2) Note the insertion handle showing
(3) Tap in a different location of text box

What is the expected result?
The second tap should trigger INSERTION_HANDLE_SHOWN.

What happens instead?
The second tap triggers INSERTION_HANDLE_MOVED.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5bcdf6b4e9f48cdbac1c3621653319e573b9b58

commit f5bcdf6b4e9f48cdbac1c3621653319e573b9b58
Author: amaralp <amaralp@chromium.org>
Date: Tue Mar 07 20:57:55 2017

Tapping/longpressing should result in INSERTION_HANDLE_SHOWN

If a touch insertion handle was visible inside of a editable text box tapping/long-
pressing somewhere else in the box caused a INSERTION_HANDLE_MOVED. This CL changes
it to cause a INSERTION_HANDLE_SHOWN. This is already how touch selection handles
work. If there is a selection and you long-press a different select this triggers
SELECTION_HANDLES_SHOWN and not SELECTION_HANDLES_MOVED.

BUG= 698376 

Review-Url: https://codereview.chromium.org/2733603003
Cr-Commit-Position: refs/heads/master@{#455214}

[modify] https://crrev.com/f5bcdf6b4e9f48cdbac1c3621653319e573b9b58/ui/touch_selection/touch_selection_controller.cc
[modify] https://crrev.com/f5bcdf6b4e9f48cdbac1c3621653319e573b9b58/ui/touch_selection/touch_selection_controller.h
[modify] https://crrev.com/f5bcdf6b4e9f48cdbac1c3621653319e573b9b58/ui/touch_selection/touch_selection_controller_unittest.cc

Comment 2 by amaralp@chromium.org, Mar 16 2017

Status: Fixed (was: Started)
►

Sign in to add a comment