This is Zach's r296887

The llvm-commits thread says it's fixed for Linux. At what revision?

Windows is still failing.

From https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/11575/steps/gclient%20runhooks/logs/stdio:

FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/Threading.cpp.obj 
C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64\cl.exe   /nologo /TP -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -IC:\b\rr\tmpbh0uhh\w\src\third_party\llvm\lib\Support -Iinclude -IC:\b\rr\tmpbh0uhh\w\src\third_party\llvm\include -DLLVM_FORCE_HEAD_REVISION /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351 -wd4355 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4800 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4324 -w14062 -we4238 /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /MT /O2 /Ob2   -UNDEBUG  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\Threading.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\ /FS -c C:\b\rr\tmpbh0uhh\w\src\third_party\llvm\lib\Support\Threading.cpp
C:\b\rr\tmpbh0uhh\w\src\third_party\llvm\lib\Support\Threading.cpp(50): error C2039: 'get_threadid_np': is not a member of 'llvm'
C:\b\rr\tmpbh0uhh\w\src\third_party\llvm\include\llvm/Support/Host.h(31): note: see declaration of 'llvm'

That's at r296906, which I think is after Zach's fixes so far

Mac at r296907:

https://build.chromium.org/p/chromium.fyi/builders/ClangToTMac/builds/13331/steps/gclient%20runhooks/logs/stdio

FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/Threading.cpp.o 
/Applications/Xcode8.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++   -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_GLOBAL_ISEL -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/b/rr/tmpC198Bu/w/src/third_party/llvm/lib/Support -Iinclude -I/b/rr/tmpC198Bu/w/src/third_party/llvm/include -DLLVM_FORCE_HEAD_REVISION -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -Werror=date-time -std=c++11 -fcolor-diagnostics -O3  -isysroot /Applications/Xcode8.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk   -UNDEBUG  -fno-exceptions -fno-rtti -MMD -MT lib/Support/CMakeFiles/LLVMSupport.dir/Threading.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/Threading.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/Threading.cpp.o -c /b/rr/tmpC198Bu/w/src/third_party/llvm/lib/Support/Threading.cpp
/b/rr/tmpC198Bu/w/src/third_party/llvm/lib/Support/Threading.cpp:50:16: error: out-of-line definition of 'get_threadid_np' does not match any declaration in namespace 'llvm'; did you mean 'get_threadid'?
uint64_t llvm::get_threadid_np() { return 0; }
               ^~~~~~~~~~~~~~~
               get_threadid
/b/rr/tmpC198Bu/w/src/third_party/llvm/include/llvm/Support/Threading.h:138:12: note: 'get_threadid' declared here
  uint64_t get_threadid();
           ^
1 error generated.

The LLVM commits message was referring to a different error, this is the first error I've seen where LLVM_ENABLE_THREADS == 0.  Do we actually build clang this way?

In any case, I can fix this error in a second.

Hopefully fixed in r296914

Thanks!

Linux looking good: https://luci-milo.appspot.com/buildbot/chromium.fyi/ClangToTLinux/7692
and Windows too: https://luci-milo.appspot.com/buildbot/chromium.fyi/ClangToTWin/11579