New issue
Advanced search Search tips

Issue 698368 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 697259



Sign in to add a comment

Improve sad tab to make it more actionable

Project Member Reported by yyushkina@chromium.org, Mar 3 2017

Issue description

Feature description: Add actionable steps for a user encountering a sad tab directly into the tab, with customized strings based on platform +(for Windows) OOM vs. Non-OOM.

Eng owner: wfh@
Product owner: yyushkina@

Mocks: go/better-sad-tab-strings
Design doc: None as string changes only

Are you planning on experimenting before launch? No
Any new strings? Yes
Any implications for Google webservices (i.e. sync, translate)? No
Binary size? N/A
Do the existing perf tests exercise all aspects of your new feature(s)? Yes

 

Comment 1 by wfh@chromium.org, Mar 3 2017

Components: -UI>Browser>NewTabPage UI>Browser
Summary: Improve sad tab to make it more actionable (was: Improve sad tab strings to make sad tab more actionable )
Strings landed in https://codereview.chromium.org/2730903006
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5c307c5f138bc029efdd63b0d8969337b4d30cf

commit c5c307c5f138bc029efdd63b0d8969337b4d30cf
Author: Will Harris <wfh@chromium.org>
Date: Mon Mar 06 06:24:35 2017

Merge M58: Add new sad tab strings.

These are being added before branch point so they can be localized.

Code will follow.

BUG=697259, 698368 

Review-Url: https://codereview.chromium.org/2730903006
Cr-Original-Commit-Position: refs/heads/master@{#454667}
Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa2774980dc4eb
Review-Url: https://codereview.chromium.org/2730903006
Cr-Commit-Position: refs/heads/master@{#454698}
(cherry picked from commit 16fe9a094fcfeacefe25e768918379cc2419d715)

Review-Url: https://codereview.chromium.org/2735653002 .
Cr-Commit-Position: refs/branch-heads/3029@{#15}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/c5c307c5f138bc029efdd63b0d8969337b4d30cf/components/new_or_sad_tab_strings.grdp

Comment 3 by wfh@chromium.org, May 12 2017

bullet list spec: http://shortn/_MtZY3KsaZT
Project Member

Comment 4 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b4b2cff058590c24232614a686a21469cdd4b1

commit d9b4b2cff058590c24232614a686a21469cdd4b1
Author: wfh <wfh@chromium.org>
Date: Thu May 18 23:05:38 2017

Fix typo in sad tab string resource.

BUG= 698368 

Review-Url: https://codereview.chromium.org/2890243002
Cr-Commit-Position: refs/heads/master@{#472961}

[modify] https://crrev.com/d9b4b2cff058590c24232614a686a21469cdd4b1/components/new_or_sad_tab_strings.grdp

Status: Fixed (was: Assigned)

Sign in to add a comment