New issue
Advanced search Search tips

Issue 698352 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK firing in ScrollbarAnimationController::PostDelayedFadeOut

Project Member Reported by bokan@chromium.org, Mar 3 2017

Issue description

Crash in ToT. I don't have a reliable repro but moving mouse around and regular use for a will trigger it.

StackTrace:

[1:5:0303/154253.235573:FATAL:scrollbar_animation_controller.cc(130)] Check failed: delayed_scrollbar_show_.IsCancelled(). 
#0 0x7f8f84d92fbb base::debug::StackTrace::StackTrace()
#1 0x7f8f84d9164c base::debug::StackTrace::StackTrace()
#2 0x7f8f84dffb4f logging::LogMessage::~LogMessage()
#3 0x7f8f7b0351b5 cc::ScrollbarAnimationController::PostDelayedFadeOut()
#4 0x7f8f7b035cb2 cc::ScrollbarAnimationController::DidMouseMoveNear()
#5 0x7f8f7b2fb43f cc::LayerTreeHostImpl::MouseMoveAt()
#6 0x7f8f7deba89f ui::InputHandlerProxy::HandleInputEvent()
#7 0x7f8f7deb9f9d ui::InputHandlerProxy::DispatchSingleInputEvent()
#8 0x7f8f7deb905c ui::InputHandlerProxy::HandleInputEventWithLatencyInfo()
#9 0x7f8f7f45c39d content::InputHandlerManager::HandleInputEvent()
#10 0x7f8f7f454cb3 content::InputEventFilter::ForwardToHandler()
#11 0x7f8f7f45890c _ZN4base8internal13FunctorTraitsIMN7content16InputEventFilterEFvRKN3IPC7MessageENS_9TimeTicksEEvE6InvokeIRK13scoped_refptrIS3_EJS7_RKS8_EEEvSA_OT_DpOT0_
#12 0x7f8f7f4587fb _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN7content16InputEventFilterEFvRKN3IPC7MessageENS_9TimeTicksEEJRK13scoped_refptrIS5_ES9_RKSA_EEEvOT_DpOT0_
#13 0x7f8f7f458774 _ZN4base8internal7InvokerINS0_9BindStateIMN7content16InputEventFilterEFvRKN3IPC7MessageENS_9TimeTicksEEJ13scoped_refptrIS4_ES6_S9_EEEFvvEE7RunImplIRKSB_RKSt5tupleIJSD_S6_S9_EEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#14 0x7f8f7f45864c _ZN4base8internal7InvokerINS0_9BindStateIMN7content16InputEventFilterEFvRKN3IPC7MessageENS_9TimeTicksEEJ13scoped_refptrIS4_ES6_S9_EEEFvvEE3RunEPNS0_13BindStateBaseE
#15 0x7f8f84d98f61 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#16 0x7f8f84d987de base::debug::TaskAnnotator::RunTask()
#17 0x7f8f84e28b1d base::MessageLoop::RunTask()
#18 0x7f8f84e28db4 base::MessageLoop::DeferOrRunPendingTask()
#19 0x7f8f84e290a4 base::MessageLoop::DoWork()
#20 0x7f8f84e40738 base::MessagePumpDefault::Run()
#21 0x7f8f84e286b7 base::MessageLoop::RunHandler()
#22 0x7f8f84ed870a base::RunLoop::Run()
#23 0x7f8f84f82fd4 base::Thread::Run()
#24 0x7f8f84f8383a base::Thread::ThreadMain()
#25 0x7f8f84f69ffa base::(anonymous namespace)::ThreadFunc()
#26 0x7f8f85203184 start_thread
#27 0x7f8f70cd437d clone
 
Reproduce:

1. Move mouse hover scrollbar
2. Move out of window, wait 1s
3. Move in window from a position far from scrollbar

Fix:
1. TaskRunner will not set delay event cancel after execute. So we need to call Cancel manually on ScrollbarAnimationControlller::Show.
2. We should also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56c267d43381c48f5fc1d1acf43550e2cd3e759a

commit 56c267d43381c48f5fc1d1acf43550e2cd3e759a
Author: chaopeng <chaopeng@chromium.org>
Date: Tue Mar 07 17:52:08 2017

Call delay_show Cancel in ScrollbarAnimationControlller::Show

This issue is caused by TaskRunner not set delay event cancel after execute. So
we need to call Cancel manually on ScrollbarAnimationControlller::Show.

We also add a Cancel in ScrollbarAnimationControlller::DidMouseLeave.

BUG= 698352 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2735603002
Cr-Commit-Position: refs/heads/master@{#455125}

[modify] https://crrev.com/56c267d43381c48f5fc1d1acf43550e2cd3e759a/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/56c267d43381c48f5fc1d1acf43550e2cd3e759a/cc/input/scrollbar_animation_controller_unittest.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment