New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698351 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

URL to the stdio is broken after switching to milo

Project Member Reported by st...@chromium.org, Mar 3 2017

Issue description

Url to the build Failure:
https://luci-milo.appspot.com/buildbot/chromium.linux/Android Builder (dbg)/118051

What is the bug or feature:

Clicking "compile stdio" leads to an error.

 

Comment 1 by st...@chromium.org, Mar 3 2017

Error: Url "https://luci-milo.appspot.com/buildbot/chromium.linux/Android Builder (dbg)/118051/steps/compile" is not pointing to a step. 
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1d65cd1d3b6d38df79d19c66633b438c53e203b2

commit 1d65cd1d3b6d38df79d19c66633b438c53e203b2
Author: Chan <chanli@chromium.org>
Date: Tue Mar 07 22:19:49 2017

[Findit] Fix error when checking failure log.

There is no milo-link for step logs - milo is using buildbot (user doesn't log in) or logdog (user has logged in).

In Findit, use the buildbot link for non-admin users and stored log for admin users.


BUG= 698351 

Change-Id: I0361736028b647dcba412f0a4f159113f115d0ba
Reviewed-on: https://chromium-review.googlesource.com/450558
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/1d65cd1d3b6d38df79d19c66633b438c53e203b2/appengine/findit/templates/waterfall/test_failure.html
[modify] https://crrev.com/1d65cd1d3b6d38df79d19c66633b438c53e203b2/appengine/findit/templates/waterfall/compile_failure.html

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1d65cd1d3b6d38df79d19c66633b438c53e203b2

commit 1d65cd1d3b6d38df79d19c66633b438c53e203b2
Author: Chan <chanli@chromium.org>
Date: Tue Mar 07 22:19:49 2017

[Findit] Fix error when checking failure log.

There is no milo-link for step logs - milo is using buildbot (user doesn't log in) or logdog (user has logged in).

In Findit, use the buildbot link for non-admin users and stored log for admin users.


BUG= 698351 

Change-Id: I0361736028b647dcba412f0a4f159113f115d0ba
Reviewed-on: https://chromium-review.googlesource.com/450558
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/1d65cd1d3b6d38df79d19c66633b438c53e203b2/appengine/findit/templates/waterfall/test_failure.html
[modify] https://crrev.com/1d65cd1d3b6d38df79d19c66633b438c53e203b2/appengine/findit/templates/waterfall/compile_failure.html

Status: Verified (was: Assigned)

Sign in to add a comment