New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698321 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug

Blocking:
issue 698366
issue 699766



Sign in to add a comment

Dismissing a paused or pending download should not cancel the download

Project Member Reported by dah...@chromium.org, Mar 3 2017

Issue description

Now that we have downloads progress + pause/resume/cancel controls in DH, we should no longer cancel/delete the download if the notification is dismissed. 

This is a ship blocker for M58.
 
Blocking: 698366
So just looked at this.  You can't swipe pending away, it's considered effectively 'in progress' until you pause it.  I think we should leave that behavior as is.  Will fix pause though.
SGTM
Cc: -qin...@chromium.org dtrainor@chromium.org
Owner: qin...@chromium.org
Min worked on this earlier today.
Labels: OS-Android
Labels: Merge-Request-58
Status: Started (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67aa8a736b47186e3ea5a2be8cc38bb7583665bd

commit 67aa8a736b47186e3ea5a2be8cc38bb7583665bd
Author: Min Qin <qinmin@chromium.org>
Date: Wed Mar 08 17:24:10 2017

Don't cancel download when dismissing the notification

TBR=dtrainor@chromium.org
BUG= 698321 

Review-Url: https://codereview.chromium.org/2729623007
Cr-Commit-Position: refs/heads/master@{#454946}
(cherry picked from commit 18aa71703fa522fbd6445fe0e3113e9b98d3c3a4)

Review-Url: https://codereview.chromium.org/2737833002 .
Cr-Commit-Position: refs/branch-heads/3029@{#64}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/67aa8a736b47186e3ea5a2be8cc38bb7583665bd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/67aa8a736b47186e3ea5a2be8cc38bb7583665bd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/67aa8a736b47186e3ea5a2be8cc38bb7583665bd/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java
[modify] https://crrev.com/67aa8a736b47186e3ea5a2be8cc38bb7583665bd/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/67aa8a736b47186e3ea5a2be8cc38bb7583665bd/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/67aa8a736b47186e3ea5a2be8cc38bb7583665bd/chrome/browser/android/download/download_manager_service.h

Blocking: 699766
Status: Fixed (was: Started)
Components: UI>Browser>Downloads

Sign in to add a comment