New issue
Advanced search Search tips

Issue 698317 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
mastiz@chromium.org
pkotw...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

We throw out downloaded favicon if a page navigates prior to download finishing

Project Member Reported by pkotw...@chromium.org, Mar 3 2017 
Currently, if a page navigates prior to a favicon download finishing, we throw out the downloaded favicon. This might be causing us to do more downloads than needed.

In FaviconHandler::OnDidDownloadFavicon() we should check whether we have downloaded the best favicon (request_next_icon == false). If so, we should store the best favicon into the database.

The goal is to reduce the number of favicon download requests done by Javascript redirect pages.

Comment 1 by pkotw...@chromium.org, Mar 3 2017

Cc: mastiz@chromium.org pkotw...@chromium.org
I tested this for twitter URL shorteners https://t.co/vzWTiCGCBp
https://t.co/vzWTiCGCBp returns a HTTP 304 redirect
- a favicon download starts
- the favicon download completes prior to the redirect occurring
I did try https://t.co/vzWTiCGCBp on a slow network but without any luck

It would be interesting to find cases in which this bug occurs in practice

Comment 2 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment