VR prompting to install when libraries already exist |
||||||
Issue descriptionVrCore prompt says to 'install' even though a version already exists on the device. This is due to the native version checker requiring a base minimum library to integrate with before it can detect that VrCore is out of date. Repro steps (on any daydream device that ships with a default version of VrCore) 1. Uninstall updates to VrCore. 2. Verify VrCore still installed and that it is stock version. 3. Load a WebVR page. Expected: See a prompt to 'update' VrCrore Actual: Prompt to 'install' VrCore is shown.
,
Mar 3 2017
,
Mar 3 2017
Please apply appropriate OS labels. Thank you.
,
Mar 3 2017
,
Mar 3 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/804a1d191525045172d6ba5c770cbf58a5ca2298 commit 804a1d191525045172d6ba5c770cbf58a5ca2298 Author: bshe <bshe@chromium.org> Date: Mon Mar 06 23:52:18 2017 Check package manager to verify VrCore is not installed BUG= 698312 Review-Url: https://codereview.chromium.org/2724903006 Cr-Commit-Position: refs/heads/master@{#454669} (cherry picked from commit 55964a5fe4fd3e1615944b0971439dd667db7521) Review-Url: https://codereview.chromium.org/2736833002 . Cr-Commit-Position: refs/branch-heads/3029@{#34} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/804a1d191525045172d6ba5c770cbf58a5ca2298/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionChecker.java [modify] https://crrev.com/804a1d191525045172d6ba5c770cbf58a5ca2298/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrCoreVersionCheckerImpl.java [modify] https://crrev.com/804a1d191525045172d6ba5c770cbf58a5ca2298/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
,
Mar 7 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 3 2017