New issue
Advanced search Search tips

Issue 698310 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Incognito mode behavior for payment apps

Project Member Reported by rouslan@chromium.org, Mar 3 2017

Issue description

Show a warning before launching into 3rd party payment apps in incognito mode.
 
 Issue 693064  has been merged into this issue.
Labels: -M-58 M-59
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0deb19af7f210edc9d644cb1240f742f755d5c2

commit d0deb19af7f210edc9d644cb1240f742f755d5c2
Author: rouslan <rouslan@chromium.org>
Date: Wed Mar 15 20:26:20 2017

Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

In addition, the "Request cancelled" rejection string is now an
AbortError, according to the spec change here:
https://github.com/w3c/browser-payment-api/commit/361e72084830d4c9aa3b09c8c1f08dc316dc71ce

The spec change is cosmetic and does not require web developers to
change their websites.

BUG= 698310 

Review-Url: https://codereview.chromium.org/2734493002
Cr-Commit-Position: refs/heads/master@{#457187}

[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFinder.java
[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/components/payments_strings.grdp
[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/d0deb19af7f210edc9d644cb1240f742f755d5c2/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified 59.0.3050.0 build
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment