Issue metadata
Sign in to add a comment
|
interactive_ui_tests broken on msan bot after switch to gtk3 |
||||||||||||||||||||||
Issue descriptionstarted here: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6074 Culprit looks like https://codereview.chromium.org/2670623002 trunk msan is happier but interactive_ui_tests is still unhappy: https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/6082 List of failing tests: AppWindowHiddenKeepAliveTest.HiddenThenShown AppWindowHiddenKeepAliveTest.ShownThenHidden AppWindowHiddenKeepAliveTest.ShownThenHiddenThenShown AppWindowHiddenKeepAliveTest.StaysHidden AppWindowInteractiveTest.ESCDoesNotLeaveFullscreenDOM AppWindowInteractiveTest.ESCDoesNotLeaveFullscreenOldPermission AppWindowInteractiveTest.ESCDoesNotLeaveFullscreenWindow AppWindowInteractiveTest.ESCLeavesFullscreenDOM AppWindowInteractiveTest.ESCLeavesFullscreenWindow AppWindowInteractiveTest.TestCreateHidden AppWindowInteractiveTest.TestDrawAttention AppWindowInteractiveTest.TestFullscreen AppWindowInteractiveTest.TestInnerBounds AppWindowTest.DisableAlwaysOnTopInFullscreen AppWindowTest.InitAlwaysOnTopToFullscreen AppWindowTest.InitFullscreenAndAlwaysOnTop AppWindowTest.InitFullscreenToAlwaysOnTop AppWindowTest.InitShowInShelf AppWindowTest.RuntimeAlwaysOnTopToFullscreen AppWindowTest.RuntimeFullscreenToAlwaysOnTop AutofillInteractiveTest.AutofillAfterReload AutofillInteractiveTest.AutofillAfterTranslate AutofillInteractiveTest.AutofillEvents AutofillInteractiveTest.AutofillFormWithNonAutofillableField AutofillInteractiveTest.AutofillFormWithRepeatedField AutofillInteractiveTest.AutofillFormsDistinguishedById AutofillInteractiveTest.AutofillSelectViaTab AutofillInteractiveTest.AutofillViaClick AutofillInteractiveTest.AutofillViaDownArrow AutofillInteractiveTest.BasicFormFill AutofillInteractiveTest.ComparePhoneNumbers AutofillInteractiveTest.DisableAutocompleteWhileFilling AutofillInteractiveTest.DontAutofillForFirstClick AutofillInteractiveTest.DontAutofillForOutsideClick AutofillInteractiveTest.DynamicFormFill AutofillInteractiveTest.InputFiresBeforeChange AutofillInteractiveTest.NoAutofillForReadOnlyFields AutofillInteractiveTest.OnChangeAfterAutofill AutofillInteractiveTest.OnDeleteValueAfterAutofill AutofillInteractiveTest.OnInputAfterAutofill AutofillInteractiveTest.OnSelectOptionFromDatalist AutofillInteractiveTest.PastedPasswordIsSaved AutofillPopupControllerBrowserTest.DeleteDelegateBeforePopupHidden AutofillPopupControllerBrowserTest.HidePopupOnWindowMove AutofillPopupControllerBrowserTest.HidePopupOnWindowResize BrowserActionInteractiveTest.BrowserClickClosesPopup1 BrowserActionInteractiveTest.BrowserClickClosesPopup2 BrowserActionInteractiveTest.CloseBrowserWithDevTools BrowserActionInteractiveTest.DeleteBrowserActionWithPopupOpen All stacks I looked at (looked through 5 arbitrarily picked tests) all look the same and look like use-after-free: Xlib: extension "RANDR" missing on display ":99". ==27082==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f645028a072 in check_interface_info_I /mnt/b/chromium/src/out-msan-chained-origins-trusty/Release/obj/third_party/instrumented_libraries/msan-libglib2.0-0.gen/libglib2.0-0/glib2.0-2.40.2/gobject/gtype.c:1070:33 #1 0x7f645028a072 in g_type_add_interface_static /mnt/b/chromium/src/out-msan-chained-origins-trusty/Release/obj/third_party/instrumented_libraries/msan-libglib2.0-0.gen/libglib2.0-0/glib2.0-2.40.2/gobject/gtype.c:2836:0 #2 0x7f644e36aada in gtk_widget_get_type /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkwidget.c:933:0 #3 0x7f644e3b2e5e in gail_focus_tracker_init /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/a11y/gtkaccessibility.c:660:0 #4 0x7f644dbe638b in ?? /mnt/b/chromium/src/out-msan-chained-origins-trusty/Release/obj/third_party/instrumented_libraries/msan-atk1.0.gen/atk1.0/atk1.0-2.10.0/atk/atkutil.c:138:7 #5 0x7f644e3b32a4 in _gtk_accessibility_init /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/a11y/gtkaccessibility.c:983:0 #6 0x7f644e242815 in do_post_parse_initialization /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkmain.c:731:0 #7 0x7f644e242815 in post_parse_hook /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkmain.c:760:0 #8 0x7f644fb7236d in g_option_context_parse /mnt/b/chromium/src/out-msan-chained-origins-trusty/Release/obj/third_party/instrumented_libraries/msan-libglib2.0-0.gen/libglib2.0-0/glib2.0-2.40.2/glib/goption.c:2096:12 #9 0x7f644e242cad in gtk_parse_args /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkmain.c:950:0 #10 0x7f644e242d08 in gtk_init_check /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkmain.c:989:0 #11 0x7f644e242d38 in gtk_init /build/gtk+3.0-3sSotQ/gtk+3.0-3.10.8/./gtk/gtkmain.c:1044:0 #12 0x1287c61f in CommonInitFromCommandLine chrome/browser/ui/libgtkui/gtk_util.cc:49:5 #13 0x1287c61f in GtkInitFromCommandLine chrome/browser/ui/libgtkui/gtk_util.cc:121:0 #14 0x1286a9d4 in GtkUi chrome/browser/ui/libgtkui/gtk_ui.cc:378:3 #15 0x12879122 in ?? chrome/browser/ui/libgtkui/gtk_ui.cc:1032:14 #16 0x11e06db7 in PreEarlyInitialization chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc:70:29 #17 0x8ce3736 in PreEarlyInitialization chrome/browser/chrome_browser_main.cc:903:29 #18 0x8b6fbaf in ?? chrome/browser/chrome_browser_main_posix.cc:115:27 #19 0x248b9ea in EarlyInitialization content/browser/browser_main_loop.cc:621:13 #20 0x24b0978 in Initialize content/browser/browser_main_runner.cc:106:19 #21 0x248869c in BrowserMain content/browser/browser_main.cc:42:32 #22 0x7eda982 in RunNamedProcessTypeMain content/app/content_main_runner.cc:491:14 #23 0x7edd62e in Run content/app/content_main_runner.cc:836:12 #24 0x7ed5ab0 in ContentMain content/app/content_main.cc:20:28 #25 0x920b2ef in SetUp content/public/test/browser_test_base.cc:312:3 #26 0x7f24c9f in SetUp chrome/test/base/in_process_browser_test.cc:258:20 #27 0xb0ae2f7 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2458:12 #28 0xb0ae2f7 in Run testing/gtest/src/gtest.cc:2470:0 #29 0xb0b13b1 in Run testing/gtest/src/gtest.cc:2656:11 #30 0xb0b2919 in Run testing/gtest/src/gtest.cc:2774:28 #31 0xb0d2e2d in RunAllTests testing/gtest/src/gtest.cc:4647:43 #32 0xb0d1c9e in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #33 0xb0d1c9e in Run testing/gtest/src/gtest.cc:4255:0 #34 0xb520460 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #35 0xb520460 in Run base/test/test_suite.cc:271:0 #36 0xa7c393 in RunTestSuite chrome/test/base/interactive_ui_tests_main.cc:85:47 #37 0x9224f11 in LaunchTests content/public/test/test_launcher.cc:520:31 #38 0xa7c1b3 in main chrome/test/base/interactive_ui_tests_main.cc:109:22 #39 0x7f6446ee1f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0 #40 0x4a99b8 in _start ??:? Uninitialized value was created by an allocation of 'xmag.i' in the stack frame of function 'g_slice_free1' #0 0x7f644fbc3740 in g_slice_free1 /mnt/b/chromium/src/out-msan-chained-origins-trusty/Release/obj/third_party/instrumented_libraries/msan-libglib2.0-0.gen/libglib2.0-0/glib2.0-2.40.2/glib/gslice.c:1078:0 Please take a look and revert if investigation takes a while.
,
Mar 3 2017
,
Mar 3 2017
Revert created in https://codereview.chromium.org/2722313008/ We need MSAN fix and need some time to get all ClusterFuzz bots updated with gtk3.
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d75f748f806d61b22012c723d63322afb2ff7208 commit d75f748f806d61b22012c723d63322afb2ff7208 Author: inferno <inferno@chromium.org> Date: Fri Mar 03 17:17:44 2017 Revert of Linux UI: Switch to the Gtk3 theme (patchset #2 id:160001 of https://codereview.chromium.org/2670623002/ ) Reason for revert: Broke MSAN bots and ClusterFuzz bots. BUG= 698239 , 698252 Original issue's description: > Linux UI: Switch to the Gtk3 theme > > Sets "use_gtk3 = true" by default. > > BUG= 79722 > TBR=dpranke@chromium.org > > > Review-Url: https://codereview.chromium.org/2670623002 > > Cr-Commit-Position: refs/heads/master@{#452118} > > Committed: https://chromium.googlesource.com/chromium/src/+/872a494bba52e597388aec738d9d681183a3d47b > > Review-Url: https://codereview.chromium.org/2670623002 > Cr-Commit-Position: refs/heads/master@{#454491} > Committed: https://chromium.googlesource.com/chromium/src/+/89be63a39b5014096115d3ec60d13fde39e73283 TBR=erg@chromium.org,mmoss@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 79722 Review-Url: https://codereview.chromium.org/2722313008 Cr-Commit-Position: refs/heads/master@{#454606} [modify] https://crrev.com/d75f748f806d61b22012c723d63322afb2ff7208/build/config/linux/gtk/gtk.gni [modify] https://crrev.com/d75f748f806d61b22012c723d63322afb2ff7208/chrome/installer/linux/debian/expected_deps_x64_jessie [modify] https://crrev.com/d75f748f806d61b22012c723d63322afb2ff7208/chrome/installer/linux/debian/expected_deps_x64_wheezy [modify] https://crrev.com/d75f748f806d61b22012c723d63322afb2ff7208/chrome/installer/linux/rpm/expected_deps_x86_64
,
Mar 3 2017
We are seeing breakages on non-msan builds as well, even thought our bots like libgtk-3-0 installed. /mnt/scratch0/clusterfuzz/slave-bot/builds/chromium-browser-asan_linux-release-v8-arm_86ad42ce63917ca43cbc6936515ab133dd9ad4fd/revisions/asan-v8-arm-linux-release-454515/chrome: error while loading shared libraries: libgtk-3.so.0: cannot open shared object file: No such file or directory
,
Mar 3 2017
Ignore C#5, 32-bit builds run in a schroot, so we need to install 32-bit version of libgtk-3-0 there.
,
Mar 3 2017
Linux debug crashes in a weird way as well. r454589 /mnt/scratch0/clusterfuzz/slave-bot/builds/chromium-browser-asan_linux-debug_4392242b7f59878a2775b4607420a2b37e17ff13/revisions/asan-linux-debug-454589/chrome --user-data-dir=/mnt/scratch0/tmp/user_profile_0 --log-net-log=/mnt/scratch0/tmp/net_log_0 --ignore-gpu-blacklist --allow-file-access-from-files --disable-gesture-requirement-for-media-playback --disable-click-to-play --disable-hang-monitor --dns-prefetch-disable --disable-default-apps --disable-component-update --safebrowsing-disable-auto-update --metrics-recording-only --disable-gpu-watchdog --disable-metrics --disable-popup-blocking --disable-prompt-on-repost --enable-experimental-extension-apis --enable-extension-apps --js-flags="--expose-gc --verify-heap" --new-window --no-default-browser-check --no-first-run --no-process-singleton-dialog --enable-shadow-dom --enable-media-stream --use-gl=osmesa --disable-gl-drawing-for-tests --use-fake-device-for-media-stream --use-fake-ui-for-media-stream Xlib: extension "RANDR" missing on display ":1". [24602:24602:0303/095750.774526:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected [24602:24602:0303/095750.774811:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected [24602:24602:0303/095752.035976:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [24602:24602:0303/095753.265953:FATAL:browser_main_loop.cc(279)] <unknown>: AT-SPI: Could not obtain desktop path or name #0 0x7f5567ff0f41 __interceptor_backtrace #1 0x7f556527a4fb base::debug::StackTrace::StackTrace() #2 0x7f5565274ff7 base::debug::StackTrace::StackTrace() #3 0x7f556540630c logging::LogMessage::~LogMessage() #4 0x7f554fc561d1 content::(anonymous namespace)::GLibLogHandler() #5 0x7f552cdfeae1 g_logv #6 0x7f552cdfed72 g_log #7 0x7f550f1bdc65 <unknown> #8 0x7f55285d6502 <unknown> #9 0x7f55285d9731 dbus_connection_dispatch #10 0x7f550de8c205 <unknown> #11 0x7f552cdf7e04 g_main_context_dispatch #12 0x7f552cdf8048 <unknown> #13 0x7f552cdf80ec g_main_context_iteration #14 0x7f55654c3609 base::MessagePumpGlib::Run() #15 0x7f556548b70a base::MessageLoop::RunHandler() #16 0x7f55656e2e17 base::RunLoop::Run() #17 0x7f556dfd3732 ChromeBrowserMainParts::MainMessageLoopRun() #18 0x7f554fc43ff1 content::BrowserMainLoop::RunMainMessageLoopParts() #19 0x7f554fc6c0ef content::BrowserMainRunnerImpl::Run() #20 0x7f554fc1f9c4 content::BrowserMain() #21 0x7f55553b045c content::RunNamedProcessTypeMain() #22 0x7f55553b8a0b content::ContentMainRunnerImpl::Run() #23 0x7f55553aaca5 content::ContentMain() #24 0x7f556807cdda ChromeMain #25 0x7f556807c9a3 main #26 0x7f55278a6f45 __libc_start_main #27 0x7f5567fa1b99 <unknown> Received signal 6 #0 0x7f5567ff0f41 __interceptor_backtrace #1 0x7f556527a4fb base::debug::StackTrace::StackTrace() #2 0x7f5565274ff7 base::debug::StackTrace::StackTrace() #3 0x7f5565278de6 base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f55291c6330 <unknown> #5 0x7f55278bbc37 gsignal #6 0x7f55278bf028 abort #7 0x7f556526c20e base::debug::(anonymous namespace)::DebugBreak() #8 0x7f556526c1db base::debug::BreakDebugger() #9 0x7f55654076aa logging::LogMessage::~LogMessage() #10 0x7f554fc561d1 content::(anonymous namespace)::GLibLogHandler() #11 0x7f552cdfeae1 g_logv #12 0x7f552cdfed72 g_log #13 0x7f550f1bdc65 <unknown> #14 0x7f55285d6502 <unknown> #15 0x7f55285d9731 dbus_connection_dispatch #16 0x7f550de8c205 <unknown> #17 0x7f552cdf7e04 g_main_context_dispatch #18 0x7f552cdf8048 <unknown> #19 0x7f552cdf80ec g_main_context_iteration #20 0x7f55654c3609 base::MessagePumpGlib::Run() #21 0x7f556548b70a base::MessageLoop::RunHandler() #22 0x7f55656e2e17 base::RunLoop::Run() #23 0x7f556dfd3732 ChromeBrowserMainParts::MainMessageLoopRun() #24 0x7f554fc43ff1 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x7f554fc6c0ef content::BrowserMainRunnerImpl::Run() #26 0x7f554fc1f9c4 content::BrowserMain() #27 0x7f55553b045c content::RunNamedProcessTypeMain() #28 0x7f55553b8a0b content::ContentMainRunnerImpl::Run() #29 0x7f55553aaca5 content::ContentMain() #30 0x7f556807cdda ChromeMain #31 0x7f556807c9a3 main #32 0x7f55278a6f45 __libc_start_main #33 0x7f5567fa1b99 <unknown> r8: 000000008fff6fff r9: 0000000000000000 r10: 0000000000000008 r11: 0000000000000202 r12: 00007f550d8b5820 r13: 00007f550d8b5a60 r14: 00000feb21b0eb00 r15: 00007f5565d4ab50 di: 000000000000601a si: 000000000000601a bp: 00007ffd5fce53c0 bx: 00007ffd5fce53e0 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007ffd5fce5288 ip: 00007f55278bbc37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. [1:1:0100/000000.975498:ERROR:broker_posix.cc(41)] Invalid node channel message Xlib: extension "RANDR" missing on display ":1". [24602:24602:0303/095750.774526:WARNING:audio_manager.cc(295)] Multiple instances of AudioManager detected [24602:24602:0303/095750.774811:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected [24602:24602:0303/095752.035976:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [24602:24602:0303/095753.265953:FATAL:browser_main_loop.cc(279)] <unknown>: AT-SPI: Could not obtain desktop path or name #0 0x7f5567ff0f41 __interceptor_backtrace #1 0x7f556527a4fb base::debug::StackTrace::StackTrace() #2 0x7f5565274ff7 base::debug::StackTrace::StackTrace() #3 0x7f556540630c logging::LogMessage::~LogMessage() #4 0x7f554fc561d1 content::(anonymous namespace)::GLibLogHandler() #5 0x7f552cdfeae1 g_logv #6 0x7f552cdfed72 g_log #7 0x7f550f1bdc65 <unknown> #8 0x7f55285d6502 <unknown> #9 0x7f55285d9731 dbus_connection_dispatch #10 0x7f550de8c205 <unknown> #11 0x7f552cdf7e04 g_main_context_dispatch #12 0x7f552cdf8048 <unknown> #13 0x7f552cdf80ec g_main_context_iteration #14 0x7f55654c3609 base::MessagePumpGlib::Run() #15 0x7f556548b70a base::MessageLoop::RunHandler() #16 0x7f55656e2e17 base::RunLoop::Run() #17 0x7f556dfd3732 ChromeBrowserMainParts::MainMessageLoopRun() #18 0x7f554fc43ff1 content::BrowserMainLoop::RunMainMessageLoopParts() #19 0x7f554fc6c0ef content::BrowserMainRunnerImpl::Run() #20 0x7f554fc1f9c4 content::BrowserMain() #21 0x7f55553b045c content::RunNamedProcessTypeMain() #22 0x7f55553b8a0b content::ContentMainRunnerImpl::Run() #23 0x7f55553aaca5 content::ContentMain() #24 0x7f556807cdda ChromeMain #25 0x7f556807c9a3 main #26 0x7f55278a6f45 __libc_start_main #27 0x7f5567fa1b99 <unknown> Received signal 6 #0 0x7f5567ff0f41 __interceptor_backtrace #1 0x7f556527a4fb base::debug::StackTrace::StackTrace() #2 0x7f5565274ff7 base::debug::StackTrace::StackTrace() #3 0x7f5565278de6 base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f55291c6330 <unknown> #5 0x7f55278bbc37 gsignal #6 0x7f55278bf028 abort #7 0x7f556526c20e base::debug::(anonymous namespace)::DebugBreak() #8 0x7f556526c1db base::debug::BreakDebugger() #9 0x7f55654076aa logging::LogMessage::~LogMessage() #10 0x7f554fc561d1 content::(anonymous namespace)::GLibLogHandler() #11 0x7f552cdfeae1 g_logv #12 0x7f552cdfed72 g_log #13 0x7f550f1bdc65 <unknown> #14 0x7f55285d6502 <unknown> #15 0x7f55285d9731 dbus_connection_dispatch #16 0x7f550de8c205 <unknown> #17 0x7f552cdf7e04 g_main_context_dispatch #18 0x7f552cdf8048 <unknown> #19 0x7f552cdf80ec g_main_context_iteration #20 0x7f55654c3609 base::MessagePumpGlib::Run() #21 0x7f556548b70a base::MessageLoop::RunHandler() #22 0x7f55656e2e17 base::RunLoop::Run() #23 0x7f556dfd3732 ChromeBrowserMainParts::MainMessageLoopRun() #24 0x7f554fc43ff1 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x7f554fc6c0ef content::BrowserMainRunnerImpl::Run() #26 0x7f554fc1f9c4 content::BrowserMain() #27 0x7f55553b045c content::RunNamedProcessTypeMain() #28 0x7f55553b8a0b content::ContentMainRunnerImpl::Run() #29 0x7f55553aaca5 content::ContentMain() #30 0x7f556807cdda ChromeMain #31 0x7f556807c9a3 main #32 0x7f55278a6f45 __libc_start_main #33 0x7f5567fa1b99 <unknown> r8: 000000008fff6fff r9: 0000000000000000 r10: 0000000000000008 r11: 0000000000000202 r12: 00007f550d8b5820 r13: 00007f550d8b5a60 r14: 00000feb21b0eb00 r15: 00007f5565d4ab50 di: 000000000000601a si: 000000000000601a bp: 00007ffd5fce53c0 bx: 00007ffd5fce53e0 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007ffd5fce5288 ip: 00007f55278bbc37 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. [1:1:0100/000000.975498:ERROR:broker_posix.cc(41)] Invalid node channel message
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49536af54da186a89cada188acbfb577843e5d46 commit 49536af54da186a89cada188acbfb577843e5d46 Author: thomasanderson <thomasanderson@google.com> Date: Wed Mar 08 00:11:56 2017 Add GTK3 and dependent instrumented libraries This cl adds a GTK3 instrumented library. It also adds libatspi and libatk-bridge which are GTK3 dependencies. Finally, update the nss patch so it applies to the latest version. BUG= 698252 R=eugenis@chromium.org Review-Url: https://codereview.chromium.org/2737783003 Cr-Commit-Position: refs/heads/master@{#455304} [modify] https://crrev.com/49536af54da186a89cada188acbfb577843e5d46/third_party/instrumented_libraries/BUILD.gn [modify] https://crrev.com/49536af54da186a89cada188acbfb577843e5d46/third_party/instrumented_libraries/patches/nss.diff [add] https://crrev.com/49536af54da186a89cada188acbfb577843e5d46/third_party/instrumented_libraries/scripts/pre-build/libgtk-3-0.sh
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05810da6bb500c8421bdd840522142b50f3265c8 commit 05810da6bb500c8421bdd840522142b50f3265c8 Author: thomasanderson <thomasanderson@google.com> Date: Wed Mar 08 06:35:34 2017 Roll instrumented libraries This CL rolls the instrumented libraries after adding Gtk3 and depedent libraries in https://codereview.chromium.org/2737783003/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng BUG= 698252 R=eugenis@chromium.org Review-Url: https://codereview.chromium.org/2736173002 Cr-Commit-Position: refs/heads/master@{#455391} [modify] https://crrev.com/05810da6bb500c8421bdd840522142b50f3265c8/third_party/instrumented_libraries/binaries/msan-chained-origins-trusty.tgz.sha1 [modify] https://crrev.com/05810da6bb500c8421bdd840522142b50f3265c8/third_party/instrumented_libraries/binaries/msan-no-origins-trusty.tgz.sha1
,
Mar 9 2017
interactive_ui_tests are no longer broken due to the revert, so closing this issue out. Please see bug 699669 for the remaining clusterfuzz issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thomasanderson@chromium.org
, Mar 3 2017