New issue
Advanced search Search tips

Issue 698243 link

Starred by 1 user
Status: Verified
Owner:
tobiasjs@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

GSA menu "help" option leads to segfault

Project Member Reported by tobiasjs@chromium.org, Mar 3 2017 
Steps to Reproduce 
1. Swipe over to -1 page in launcher 
2. Tap on hamburger menu 
3. Tap on "help" 

Expected Results 
Something helpful 

Observed Results 
Interface freezes and then restarts.  Logcat suggests a segmentation fault. 

webview version: 58.0.3019.3

It's segfaulting without printing a microdump, so we only get one address to go on:
0x00000000020eda80: breakpad::HandleCrashDump(breakpad::BreakpadInfo const&)
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec2b22c83c792439a84157ee7bc6c900ea89c09

commit dec2b22c83c792439a84157ee7bc6c900ea89c09
Author: tobiasjs <tobiasjs@chromium.org>
Date: Wed Mar 08 10:58:49 2017

aw: Do not DumpWithoutCrashing if crash reporter is not enabled.

GSA can apparently use the AwDebug reflection interface at a
point where WebView (and hence the crash reporter) hasn't been
initialized yet. We should just fail in this case.

BUG= 698243 

Review-Url: https://codereview.chromium.org/2729093004
Cr-Commit-Position: refs/heads/master@{#455426}

[modify] https://crrev.com/dec2b22c83c792439a84157ee7bc6c900ea89c09/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Comment 2 by tobiasjs@chromium.org, Mar 8 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 8 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/689d4697449918c2345e0600cfc85cd89cc45f42

commit 689d4697449918c2345e0600cfc85cd89cc45f42
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Wed Mar 08 11:34:55 2017

aw: Do not DumpWithoutCrashing if crash reporter is not enabled.

GSA can apparently use the AwDebug reflection interface at a
point where WebView (and hence the crash reporter) hasn't been
initialized yet. We should just fail in this case.

BUG= 698243 

Review-Url: https://codereview.chromium.org/2729093004
Cr-Commit-Position: refs/heads/master@{#455426}
(cherry picked from commit dec2b22c83c792439a84157ee7bc6c900ea89c09)

Review-Url: https://codereview.chromium.org/2735173003 .
Cr-Commit-Position: refs/branch-heads/3029@{#61}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/689d4697449918c2345e0600cfc85cd89cc45f42/android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc

Comment 5 by tobiasjs@chromium.org, Mar 8 2017

Status: Fixed (was: Assigned)

Comment 6 by sbash...@chromium.org, Mar 14 2017

Status: Verified (was: Fixed)
Verified in 58.0.2883.91 on Nexus 6(N247I).
►

Sign in to add a comment