It's not used per-document and is only toggled on/off depending on the platform. The overhead of having this as a setting isn't worth it and makes writing tests slightly more annoying than it should.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81 commit 48a24fcc7bcf3f9c02faf6b1e949eed37f246c81 Author: mlamouri <mlamouri@chromium.org> Date: Sat Mar 04 13:44:37 2017 Media Controls: make the MediaControlsOverlayPlayButton a runtime enabled flag. It doesn't need to be a settings because it is not used on a document basis but on a platform basis. A runtime enabled flag has a lower overhead and is easier to work with because there is no need for a settings object to be available, making tests easier to write. BUG= 698237 Review-Url: https://codereview.chromium.org/2728133002 Cr-Commit-Position: refs/heads/master@{#454771} [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/chromecast/renderer/cast_content_renderer_client.cc [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/chromecast/renderer/cast_content_renderer_client.h [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/content/child/runtime_features.cc [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/content/renderer/render_view_impl.cc [add] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/LayoutTests/media/controls/video-overlay-play-button.html [delete] https://crrev.com/3665df287a6774280935e96a466271ec4acbe9f9/third_party/WebKit/LayoutTests/media/video-controls-overlay-play-button.html [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/Source/core/frame/Settings.json5 [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/Source/web/WebSettingsImpl.cpp [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/Source/web/WebSettingsImpl.h [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/public/web/WebRuntimeFeatures.h [modify] https://crrev.com/48a24fcc7bcf3f9c02faf6b1e949eed37f246c81/third_party/WebKit/public/web/WebSettings.h
Comment 1 by mlamouri@chromium.org
, Mar 3 2017