New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698236 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

git cl comment for Gerrit

Project Member Reported by tandrii@chromium.org, Mar 3 2017

Issue description

Missing functionality vs Rietveld.
Not sure it is actually necessary.
 
Labels: -Restrict-View-Google Milestone-Launch Proj-Gerrit-Migration
Cc: aga...@chromium.org
Cc: -aga...@chromium.org
Labels: Pri-2
Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by aga...@chromium.org, Mar 14 2017

Cc: aga...@chromium.org andyb...@chromium.org
Owner: tandrii@chromium.org
tandrii, since you've done the most work inside git-cl and since you're in the same timezone as the original `git cl comments` author (apavlov), can you please take this?
Status: Started (was: Assigned)
First CL: https://chromium-review.googlesource.com/c/455877/ 
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/625986dba7852518199ec002fd4cece02929f4ab

commit 625986dba7852518199ec002fd4cece02929f4ab
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Mar 17 09:58:05 2017

git cl comment: implement adding comment for Gerrit.

BUG= 698236 

Change-Id: Ia1a36af71c348be991d77083092c5043c2642c19
Reviewed-on: https://chromium-review.googlesource.com/455877
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/625986dba7852518199ec002fd4cece02929f4ab/tests/git_cl_test.py
[modify] https://crrev.com/625986dba7852518199ec002fd4cece02929f4ab/git_cl.py

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/d8aa49f35b8d3e981d0afc3d539aae35a2f89415

commit d8aa49f35b8d3e981d0afc3d539aae35a2f89415
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Mar 17 15:09:55 2017

git cl comment: refactor fetching comments for Rietveld and add tests.

R=agable@chromium.org,machenbach@chromium.org
BUG= 698236 

Change-Id: I04e264130952e3e270540fae8381db544cf40e7c
Reviewed-on: https://chromium-review.googlesource.com/456697
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/d8aa49f35b8d3e981d0afc3d539aae35a2f89415/tests/git_cl_test.py
[modify] https://crrev.com/d8aa49f35b8d3e981d0afc3d539aae35a2f89415/git_cl.py

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/5a0cf20452b7dac174dd0377f5b030379ba543ef

commit 5a0cf20452b7dac174dd0377f5b030379ba543ef
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Mar 17 15:28:34 2017

git cl comment: implement fetching comments for Gerrit.

R=agable@chromium.org,machenbach@chromium.org
BUG= 698236 

Change-Id: I36dcd2f10d0518a9f04a766e09c1ab00f2ce4d3b
Reviewed-on: https://chromium-review.googlesource.com/456699
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/5a0cf20452b7dac174dd0377f5b030379ba543ef/tests/git_cl_test.py
[modify] https://crrev.com/5a0cf20452b7dac174dd0377f5b030379ba543ef/git_cl.py

Status: Fixed (was: Started)
OK, what remains is this backwards incompatible change that
requires the use of --rietveld if --issue is used:

https://chromium-review.googlesource.com/456700

However, the functionality is here and so this bug is fixed.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a

commit 0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Mar 20 12:35:09 2017

git cl comment: require explicit --codereview with -i|--issue flag.

R=agable@chromium.org,machenbach@chromium.org
BUG= 698236 

Change-Id: If79f938e457f176c47badd75f78ed4ecb764ec2d
Reviewed-on: https://chromium-review.googlesource.com/456700
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a/tests/git_cl_test.py
[modify] https://crrev.com/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a/git_cl.py

Sign in to add a comment