Issue metadata
Sign in to add a comment
|
git cl comment for Gerrit |
||||||||||||||||||||||
Issue descriptionMissing functionality vs Rietveld. Not sure it is actually necessary.
,
Mar 5 2017
,
Mar 5 2017
,
Mar 14 2017
tandrii, since you've done the most work inside git-cl and since you're in the same timezone as the original `git cl comments` author (apavlov), can you please take this?
,
Mar 16 2017
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/625986dba7852518199ec002fd4cece02929f4ab commit 625986dba7852518199ec002fd4cece02929f4ab Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Mar 17 09:58:05 2017 git cl comment: implement adding comment for Gerrit. BUG= 698236 Change-Id: Ia1a36af71c348be991d77083092c5043c2642c19 Reviewed-on: https://chromium-review.googlesource.com/455877 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/625986dba7852518199ec002fd4cece02929f4ab/tests/git_cl_test.py [modify] https://crrev.com/625986dba7852518199ec002fd4cece02929f4ab/git_cl.py
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d8aa49f35b8d3e981d0afc3d539aae35a2f89415 commit d8aa49f35b8d3e981d0afc3d539aae35a2f89415 Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Mar 17 15:09:55 2017 git cl comment: refactor fetching comments for Rietveld and add tests. R=agable@chromium.org,machenbach@chromium.org BUG= 698236 Change-Id: I04e264130952e3e270540fae8381db544cf40e7c Reviewed-on: https://chromium-review.googlesource.com/456697 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/d8aa49f35b8d3e981d0afc3d539aae35a2f89415/tests/git_cl_test.py [modify] https://crrev.com/d8aa49f35b8d3e981d0afc3d539aae35a2f89415/git_cl.py
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/5a0cf20452b7dac174dd0377f5b030379ba543ef commit 5a0cf20452b7dac174dd0377f5b030379ba543ef Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Fri Mar 17 15:28:34 2017 git cl comment: implement fetching comments for Gerrit. R=agable@chromium.org,machenbach@chromium.org BUG= 698236 Change-Id: I36dcd2f10d0518a9f04a766e09c1ab00f2ce4d3b Reviewed-on: https://chromium-review.googlesource.com/456699 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/5a0cf20452b7dac174dd0377f5b030379ba543ef/tests/git_cl_test.py [modify] https://crrev.com/5a0cf20452b7dac174dd0377f5b030379ba543ef/git_cl.py
,
Mar 17 2017
OK, what remains is this backwards incompatible change that requires the use of --rietveld if --issue is used: https://chromium-review.googlesource.com/456700 However, the functionality is here and so this bug is fixed.
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a commit 0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Mar 20 12:35:09 2017 git cl comment: require explicit --codereview with -i|--issue flag. R=agable@chromium.org,machenbach@chromium.org BUG= 698236 Change-Id: If79f938e457f176c47badd75f78ed4ecb764ec2d Reviewed-on: https://chromium-review.googlesource.com/456700 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a/tests/git_cl_test.py [modify] https://crrev.com/0d6b46e32b99c7f6b7ecef5cde843aaf4e43449a/git_cl.py |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Mar 3 2017