New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698234 link

Starred by 1 user
Status: Fixed
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Mar 2017
Cc:
█ bauerb@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

NTP Snap scrolls inappropriately

Project Member Reported by dgn@chromium.org, Mar 3 2017 
Repro:
1. Check that your search engine is Google
2. Open NTP
3. Change your search engine to something else (e.g. Yahoo)
4. Go back to that previously opened NTP
5. Scroll down slowly
6. Let go around the moment when NTP tiles reach the top

Expected: nothing happens
Actual: the NTP scrolls further up. This is the snap scroll that was supposed to apply to the fakebox that still runs even though there is no fakebox
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34094a69914e0cdc9a3215a0b53284d6f55c5b27

commit 34094a69914e0cdc9a3215a0b53284d6f55c5b27
Author: dgn <dgn@chromium.org>
Date: Fri Mar 03 16:13:39 2017

[NTP Client] Only snap scroll when there is a fakebox

Makes sure the RecyclerView does not calculate snap positions for
the fakebox when it has been hidden after initialisation.

BUG= 698234 

Review-Url: https://codereview.chromium.org/2730923002
Cr-Commit-Position: refs/heads/master@{#454592}

[modify] https://crrev.com/34094a69914e0cdc9a3215a0b53284d6f55c5b27/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Comment 2 by dgn@chromium.org, Mar 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment