Remove device_setup.FlagReplacer in toold/android/loading |
||
Issue descriptionWhy? - flag_changer.CustomCommandLineFlags in devil should be a drop-in replacement. - we're adding logic to CustomCommandLineFlags so flags can be read without issues in Android N+, so you would get this for free; see: https://github.com/catapult-project/catapult/issues/3172 The only difference appears to be that device_setup.FlagReplacer allows the device to be None (and then the context manager behaves as a no-op). But all clients I've seen assume that the device is not None (they go ahead and access more of its methods). Is this feature really needed? cc'ing some owners of tools/android/loading for comment.
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdc24416fa0ca3fa946506f299d3d36d39cb36a1 commit bdc24416fa0ca3fa946506f299d3d36d39cb36a1 Author: perezju <perezju@chromium.org> Date: Wed Mar 08 11:45:04 2017 [tools/android] Replace FlagReplacer with flag_changer equivalent flag_changer.CustomCommandLineFlags is now a drop-in replacement for device_setup.FlagReplacer. This also helps keeping the code to deal with command line files in one place, which can be tweaked as needed to work well on future Android and Chrome versions. BUG= 698205 Review-Url: https://codereview.chromium.org/2733233002 Cr-Commit-Position: refs/heads/master@{#455433} [modify] https://crrev.com/bdc24416fa0ca3fa946506f299d3d36d39cb36a1/tools/android/customtabs_benchmark/scripts/customtabs_benchmark.py [modify] https://crrev.com/bdc24416fa0ca3fa946506f299d3d36d39cb36a1/tools/android/loading/controller.py [modify] https://crrev.com/bdc24416fa0ca3fa946506f299d3d36d39cb36a1/tools/android/loading/device_setup.py [modify] https://crrev.com/bdc24416fa0ca3fa946506f299d3d36d39cb36a1/tools/android/loading/wpr_helper.py [modify] https://crrev.com/bdc24416fa0ca3fa946506f299d3d36d39cb36a1/tools/resource_prefetch_predictor/prefetch_benchmark.py
,
Sep 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by pasko@chromium.org
, Mar 6 2017