New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698176 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression: Unnecessary flickering is seen on context menu in Files.app

Project Member Reported by sandeepkumars@chromium.org, Mar 3 2017

Issue description

Chrome Version: 58.0.3027.0/9332.0.0 dev-channel Samus, Parrot
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to user>> go to Files.app>> go to my drive or downloads tab>> Right click open context menu>> create one folder>> and observe context menu

Expected: Unnecessary flickering should not be seen on context menu (Please refer video)
Actual: Instead flickering is seen

Raising this issue as Non-Regression issue as same behavior is seen since M55

Issue is not applicable to Linux and Windows

 
Actual-Context_Menu.webm
1.6 MB View Download
Labels: -M-58

Comment 2 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp-UI
Owner: ----
Status: Unconfirmed (was: Assigned)

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-UI CrOSFilesCategory-UI

Comment 5 by dats@google.com, Mar 14 2018

Cc: krajshree@chromium.org brajkumar@chromium.org
 Issue 758534  has been merged into this issue.

Comment 6 by dats@google.com, Mar 14 2018

Status: Untriaged (was: Unconfirmed)
It does happen. Not very visible though, just some funky flicker when you click menu item, you need slomo video to clearly see it. Not sure it's Files app specific or general framework problem.

Comment 7 by sashab@chromium.org, Apr 12 2018

Cc: noel@chromium.org
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Comment 8 by noel@chromium.org, Apr 12 2018

Cc: dats@chromium.org
dats@ do you recall the bug you filed about flickering in the toolbar?  This one sounds very similar to me.

Comment 9 by dats@chromium.org, Apr 12 2018

This is a little bit different. Here what apparently happens is when one clicks menu item, instead of more or less immediately dismissing the menu, it sits on the screen for several render passes with clicked item disabled/enabled meanwhile. This at real speed looks like menu flickering.

In the toolbar though it's by design - the layout depends on the selection, which inevitably gets processed with some delay, so buttons appear/disappear with some delay after changing selection, which looks confusing.

Comment 10 by noel@google.com, Apr 12 2018

Thanks and agree: flashing/flickering => confusion/irritation for our users.
Labels: Files-Fixit-2018
Owner: adanilo@chromium.org
Status: Started (was: Available)
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/486368907e4b373729c4a1671ca6003ac4efbf7c

commit 486368907e4b373729c4a1671ca6003ac4efbf7c
Author: Alex Danilo <adanilo@chromium.org>
Date: Thu Nov 22 02:37:03 2018

Remove unnecessary context menu flicker

Context menu 'New Folder' selection was causing the menu to jump
up and down (easier seen on captured video on the bug). This was
caused by a 'change' event fired that updated the state of the
context menu tasks-separator bar to visible despite there being
no items above it (which in turn, makes the menu taller temporarily).
That happened mid-animation of the menu and the bar is reset to
hidden after more event processing. Removing the fake data that
was passed into the updateContextMenuTaskItems_() method stops
it happening.

      offending code to visually check fix works. Ran test on
      desktop and real device to confirm.

Bug:  698176 
Test: Ran all FilesApp browser tests. Single-stepped through the
Change-Id: Icd7a2c41ad85bf93e30fe90632d83a8890b294bf
Reviewed-on: https://chromium-review.googlesource.com/c/1347631
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610283}
[modify] https://crrev.com/486368907e4b373729c4a1671ca6003ac4efbf7c/ui/file_manager/file_manager/foreground/js/task_controller.js

Status: Fixed (was: Started)

Sign in to add a comment