Issue metadata
Sign in to add a comment
|
Regression : Cursor is not seen in the omnibox after entering any single alphabet in NTP 'Search box'.
Reported by
yfulgaon...@etouch.net,
Mar 3 2017
|
||||||||||||||||||||||
Issue descriptionChrome version : 58.0.3029.0 (Official Build) 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} 32/64 bit OS : Windows (7,8,8.1,10), Linux (14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP, click inside the 'Search box' and enter any single alphabet like 'g' 2. Observe the omnibox. Actual : Cursor is not seen in omnibox after entering any single alphabet in the 'Search box'. Expected : Cursor should be seen in omnibox after entering any single alphabet in 'Search box'. This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info. Good build : 58.0.3028.0 Bad build : 58.0.3029.0 Note : 1. Above issue is reproducible on Windows(7,8,8.1,10), Linux (14.04 LTS) OS and it is working fine on Mac (10.11.6, 10.12.1, 10.12) OS. 2. Issue is seen only when a single alphabet is entered in the search box and cursor appears after entering the next character.
,
Mar 3 2017
Bisect Info: =========== Good build : 58.0.3028.0, Revision Range- 454140 Bad build : 58.0.3029.0, Revision Range- 454471 After executing the per-revision-bisect script, i got the following CL's between good and bad build versions ============================================ https://chromium.googlesource.com/chromium/src/+log/7f57605b9ac7dd12449a7fc6494a74786959785b..413ab9af7d2755e3287b07b08c21fc3be062103c The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/413ab9af7d2755e3287b07b08c21fc3be062103c Review-Url: https://codereview.chromium.org/2728433002 yiyix@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner. Thank You...
,
Mar 3 2017
Adding Release block elabel, please undo if not the case.
,
Mar 3 2017
,
Mar 7 2017
the cursor also disappear if you copy paste something to the Search box and do not enter any new chars. I am also fixing that issue here.
,
Mar 7 2017
Just to update, M-58 will be promoted to Beta next week, since this is marked as Beta blocker please plan the fix accordingly.
,
Mar 10 2017
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c57eaf40e82246d8acb9f58a350ef1a619cb19b1 commit c57eaf40e82246d8acb9f58a350ef1a619cb19b1 Author: yiyix <yiyix@chromium.org> Date: Mon Mar 13 18:42:37 2017 Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box' After any alphabet is entered in 'Search box', Textfield::DoInsertChar is called and it first updates the cursor visibility by calling UpdateAfterChange then it calls OnAfterUserAction to update the textfield focus and which may change the cursor visibility. If the cursor visibility is changed in OnAfterUserAction, the text cursor will not being updated again. The previous CL (https://codereview.chromium.org/2728433002/) exposed this wrong order of updating. TEST=TextfieldTest.CursorVisibilityChangeAfterInserting BUG= 698172 Review-Url: https://codereview.chromium.org/2729133005 Cr-Commit-Position: refs/heads/master@{#456444} [modify] https://crrev.com/c57eaf40e82246d8acb9f58a350ef1a619cb19b1/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/c57eaf40e82246d8acb9f58a350ef1a619cb19b1/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/c57eaf40e82246d8acb9f58a350ef1a619cb19b1/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/c57eaf40e82246d8acb9f58a350ef1a619cb19b1/ui/views/controls/textfield/textfield_unittest.cc
,
Mar 14 2017
Verified the fix on the latest M-59(59.0.3041.0) on Windows-10 and Linux Ubuntu 14.04. This is working as intended and cursor is seen in the omnibox upon entering single letter in the NTP search box. yiyix@: Could you please get the fix merged to M-58 as well.
,
Mar 14 2017
,
Mar 14 2017
,
Mar 14 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2017
M58 will be promoted to Beta soon.Please merge your change ASAP.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddae604aa75d462f6cfde9bed6744a2bc113bed2 commit ddae604aa75d462f6cfde9bed6744a2bc113bed2 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Wed Mar 15 06:33:19 2017 Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box' After any alphabet is entered in 'Search box', Textfield::DoInsertChar is called and it first updates the cursor visibility by calling UpdateAfterChange then it calls OnAfterUserAction to update the textfield focus and which may change the cursor visibility. If the cursor visibility is changed in OnAfterUserAction, the text cursor will not being updated again. The previous CL (https://codereview.chromium.org/2728433002/) exposed this wrong order of updating. TEST=TextfieldTest.CursorVisibilityChangeAfterInserting BUG= 698172 Review-Url: https://codereview.chromium.org/2729133005 Cr-Commit-Position: refs/heads/master@{#456444} (cherry picked from commit c57eaf40e82246d8acb9f58a350ef1a619cb19b1) Review-Url: https://codereview.chromium.org/2754633002 . Cr-Commit-Position: refs/branch-heads/3029@{#200} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/ddae604aa75d462f6cfde9bed6744a2bc113bed2/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/ddae604aa75d462f6cfde9bed6744a2bc113bed2/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/ddae604aa75d462f6cfde9bed6744a2bc113bed2/ui/views/controls/textfield/textfield.h [modify] https://crrev.com/ddae604aa75d462f6cfde9bed6744a2bc113bed2/ui/views/controls/textfield/textfield_unittest.cc
,
Mar 15 2017
Just to update the behavior of this wrt 'Needs-triage-Mobile' label added in C#7. Tested this on: ================ Chrome version: latest M-58(58.0.3029.23/3029@198) which doesn't contain the merge from C#14. Devices tested: Samsung Galaxy S2 tablet and Moto G Handset. Platform tested:(Android 6.0.1; SM-T815Y Buid/MMB29K) and (Android 6.0.0 XT1068 motoG Build/MBP24.65-34-3) Issue is not reproducible on Android as per the above test on Tablet and Handset.
,
Mar 15 2017
,
Mar 22 2017
Verified this issue on Windows 10, Ubuntu 14.04 and Mac 10.12.3 with chrome #58.0.3029.33 ,followed the steps mentioned in the comment #0 Observed the cursor is seen in omnibox after entering any single alphabet in 'Search box'. Attaching the screen-cast for reference. Hence adding TE-Verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by treib@chromium.org
, Mar 3 2017