New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698171 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add "No image background" on suggested article

Project Member Reported by gambard@chromium.org, Mar 3 2017

Issue description

When no image is available or not downloaded yet, a specific background should be shown for the suggested article image
 
Components: UI>Browser>NewTabPage
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99ee0570b40f1e61e27a35d8b41c52e892e0fd01

commit 99ee0570b40f1e61e27a35d8b41c52e892e0fd01
Author: gambard <gambard@chromium.org>
Date: Mon Mar 06 18:01:34 2017

Default background for suggested article images

This CL adds a uniform grey background for the suggested articles' image,
which is displayed until a fetched image is displayed.

BUG= 698171 

Review-Url: https://codereview.chromium.org/2734763003
Cr-Commit-Position: refs/heads/master@{#454884}

[modify] https://crrev.com/99ee0570b40f1e61e27a35d8b41c52e892e0fd01/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.mm
[modify] https://crrev.com/99ee0570b40f1e61e27a35d8b41c52e892e0fd01/ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item_unittest.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a1acac93195ccb06ca7d19fc40c1d81be32987b

commit 3a1acac93195ccb06ca7d19fc40c1d81be32987b
Author: gambard <gambard@chromium.org>
Date: Tue Mar 28 17:01:12 2017

Add no-image image in ContentSuggestions

Add a background image displayed while the application is fetching the images
or if there is no image for a suggestion.

BUG= 698171 

Review-Url: https://codereview.chromium.org/2770113006
Cr-Commit-Position: refs/heads/master@{#460139}

[modify] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.h
[modify] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
[modify] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm
[add] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image.png
[add] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image@2x.png
[add] https://crrev.com/3a1acac93195ccb06ca7d19fc40c1d81be32987b/ios/chrome/browser/ui/content_suggestions/resources/content_suggestions_no_image@3x.png

Status: Fixed (was: Assigned)

Sign in to add a comment