New issue
Advanced search Search tips

Issue 698143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 31
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Strip "DISABLED_" prefix for gtest ran on Android

Project Member Reported by st...@chromium.org, Mar 3 2017

Issue description

Currently in the output.json for gtests on Android, disabled test still has the "DISABLED_" prefix. Example https://chromium-swarm.appspot.com/task?id=34ab245d88aff310

This bug is to make it in parity with gtest results on desktop produced by base/test/launcher.

Currently Findit assumes that "DISABLED_" is stripped from the test name, because that's how base/test/launcher does for gtests on desktop.

If "DISABLED_" is not stripped, Findit would fail to get the result for the test run, and  treat the test as not existing like https://findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb3ItbWVysQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ7Y2hyb21pdW0ubGludXgvQW5kcm9pZCBUZXN0cy8zODgxOS9kZXZpY2VfdW5pdHRlc3RzIG9uIEFuZHJvaWQvUjJGdFpYQmhaRkJ5YjNacFpHVnlWR1Z6ZEM1RGIyNXVaV04wUkdselkyOXVibVZqZEUxMWJIUnBjR3hsDAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
 
Owner: shenghua...@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0287a23d5d61345ca9c246b5119ab78e80305eb

commit d0287a23d5d61345ca9c246b5119ab78e80305eb
Author: shenghuazhang <shenghuazhang@chromium.org>
Date: Wed Mar 15 18:57:31 2017

[Android] Strip 'DISABLED_' test name prefix for gtest

Currently the gtest results output has the 'DISABLED_' prefix on
disabled tests. This CL strips the 'DISABLED_' prefix for gtest results
output, which matches gtest results on desktop produced by
//base/test/launcher.

BUG= 698143 

Review-Url: https://codereview.chromium.org/2754463004
Cr-Commit-Position: refs/heads/master@{#457155}

[modify] https://crrev.com/d0287a23d5d61345ca9c246b5119ab78e80305eb/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/d0287a23d5d61345ca9c246b5119ab78e80305eb/build/android/pylib/local/device/local_device_gtest_run.py

Cc: -shenghua...@chromium.org
Owner: ----
Status: Available (was: Started)
Status: Fixed (was: Available)

Sign in to add a comment