New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698138 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: gooftool probe result should contain region value

Project Member Reported by hungte@chromium.org, Mar 3 2017

Issue description

Sometimes we need to verify and debug on HWID encode errors. And to do this, we tell partners to upload the probed-results.

However, I'm seeing a problem now that probed-results do not include region (even if it includes firmware hashes).

I think we should include region in the probed-results so we can re-encode by device info file and probed results.
 
Do you run the command with argument "gooftool probe --include_vpd"? The region code should be included in the probe result when the argument is enable.
Hmmm I think you're right, but I think it probably makes more sense to include vpd by default if --fast_fw_probe was not set to true, especially that the only VPD class is 'region' now.

Comment 3 by hungte@chromium.org, May 18 2017

Cc: akahuang@chromium.org
Owner: yhong@chromium.org

Comment 4 by hungte@chromium.org, Jul 26 2017

Cc: -akahuang@chromium.org chromeos-factory-eng@google.com

Comment 5 by yhong@chromium.org, Oct 30 2017

Status: WontFix (was: Untriaged)
As `gooftool probe` is going to be deprecated, let's mark this bug to WontFix first.

Comment 6 by hungte@chromium.org, Oct 30 2017

will you have other issue tracking that probe results should contain region values?

Comment 7 by yhong@chromium.org, Oct 30 2017

The use-case of the new probe framework is different than `gooftool probe` so for now I'm not very sure.  I will make the final decision after I finish to replace all use-cases of `gooftool probe` by `probe`.  Maybe at that time the generic probing method of `probe` will probe the region field from vpd in default.

Sign in to add a comment