external/wpt/editing/run/delete.htm crashes |
|||||
Issue descriptionChrome Version: ToT OS: OSX What steps will reproduce the problem? (1) With Debug build, run-webkit-tests external/wpt/editing/run/delete.html What is the expected result? Not crash What happens instead? Dcheck fail. [16424:52483:0303/133247.017540:1574369503546188:FATAL:CompositeEditCommand.cpp(1389)] Check failed: isStartOfParagraph(startOfParagraphToMove). SPAN style="display:inline-table" (editable)@afterAnchor/TextAffinity::Downstream 4 libbase.dylib logging::LogMessage::~LogMessage() + 21 5 libblink_core.dylib blink::CompositeEditCommand::moveParagraph(blink::VisiblePositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, blink::VisiblePositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, blink::VisiblePositionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, blink::EditingState*, blink::CompositeEditCommand::ShouldPreserveSelection, blink::CompositeEditCommand::ShouldPreserveStyle, blink::Node*) + 439 6 libblink_core.dylib blink::DeleteSelectionCommand::mergeParagraphs(blink::EditingState*) + 3159 7 libblink_core.dylib blink::DeleteSelectionCommand::doApply(blink::EditingState*) + 1763 8 libblink_core.dylib blink::CompositeEditCommand::applyCommandToComposite(blink::EditCommand*, blink::EditingState*) + 86 9 libblink_core.dylib blink::CompositeEditCommand::deleteSelection(blink::VisibleSelectionTemplate<blink::EditingAlgorithm<blink::NodeTraversal> > const&, blink::EditingState*, bool, bool, bool, bool) + 181 10 libblink_core.dylib blink::TypingCommand::deleteKeyPressed(blink::TextGranularity, bool, blink::EditingState*) + 2995 11 libblink_core.dylib blink::TypingCommand::doApply(blink::EditingState*) + 318 12 libblink_core.dylib blink::CompositeEditCommand::apply() + 701 13 libblink_core.dylib blink::TypingCommand::deleteKeyPressed(blink::Document&, unsigned int, blink::TextGranularity) + 261 14 libblink_core.dylib blink::executeDelete(blink::LocalFrame&, blink::Event*, blink::EditorCommandSource, WTF::String const&) + 359 15 libblink_core.dylib blink::Editor::Command::execute(WTF::String const&, blink::Event*) const + 564 16 libblink_core.dylib blink::Document::execCommand(WTF::String const&, bool, WTF::String const&, blink::ExceptionState&) + 524
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d48625f7b09df0495e40c7c1ff1cafe00e5693b commit 3d48625f7b09df0495e40c7c1ff1cafe00e5693b Author: tkent <tkent@chromium.org> Date: Fri Mar 03 05:37:41 2017 Update TestExpectations and SlowTests a little bit. - Remove external/wpt/selection/selectAllChildren.html from SlowTests. The test already has a <meta> for long timeout. - Update bug numbers for LinkStyle.html and delete.html BUG=692560,698135 NOTRY=true TBR=yosin@chromomium.org Review-Url: https://codereview.chromium.org/2729103002 Cr-Commit-Position: refs/heads/master@{#454519} [modify] https://crrev.com/3d48625f7b09df0495e40c7c1ff1cafe00e5693b/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/3d48625f7b09df0495e40c7c1ff1cafe00e5693b/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 6 2017
,
Mar 6 2017
,
Mar 7 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2018
This doesn't crash recently. We can close this issue by * Check in -expected.txt * Remove the entry from TestExpectation
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e89eb17c67ef2a60e38029deb9640808953442e commit 1e89eb17c67ef2a60e38029deb9640808953442e Author: Javier Fernandez <jfernandez@igalia.com> Date: Wed Jul 04 12:33:54 2018 Remove failure expectations for some editing web platform tests Bug 751952 has been fixed a while ago, so I think we can remove the failure expectation for the forwardDelete.html test. Additionally, there are some comments in bug 698135 that indicate the crash is not reproducible anymore, which was the reason why there was a failure entry for the delete.html test. This CL removes the related entries in the TestExpectations file and provides a new expected file for the delete.html test. It keeps, though, a Failure entry for Mac only in the case of the delete.html, since there are clear interoperability issues with Mac for these use cases. BUG=698135 Change-Id: I973b84eb1ea19fa72ba4011001aa750b73e87b0c Reviewed-on: https://chromium-review.googlesource.com/1124461 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#572543} [modify] https://crrev.com/1e89eb17c67ef2a60e38029deb9640808953442e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1e89eb17c67ef2a60e38029deb9640808953442e/third_party/WebKit/LayoutTests/external/wpt/editing/run/delete-expected.txt |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkent@chromium.org
, Mar 3 2017