New issue
Advanced search Search tips

Issue 698134 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make LogoutButtonTray a regular View (rather than TrayBackgroundView)

Project Member Reported by moh...@chromium.org, Mar 3 2017

Issue description

Currently, LogoutButtonTray is a TrayBackgroundView. However, it does not use most of the functionality that TrayBackgroundView provides (e.g. does not have background or separators, does not use click logic of ActionableView). Consider making it a regular View.
 

Comment 1 by moh...@chromium.org, Mar 30 2017

Labels: -Restrict-View-Google
Status: Started (was: Assigned)
Labels: M-59
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6704a0c2b29585fab489399ba0396104cff7d85

commit e6704a0c2b29585fab489399ba0396104cff7d85
Author: mohsen <mohsen@chromium.org>
Date: Thu Apr 20 06:30:20 2017

Make LogoutButtonTray a regular View

Currently, LogoutButtonTray is a TrayBackgroundView, however, it does
not use most of its functionality (e.g., drawing and animating
background, handling bubbles, drawing separators and focus rings). This
CL makes LogoutButtonTray directly inherit from View and just adds the
padding using TrayContainer class.

This CL also removes shelf alignment caching in TrayBackgroundView,
TrayContainer, and StatusAreaWidgetDelegate and cleaned up some related
shelf alignment code.

BUG= 698134 , 635963 
TEST=StatusAreaWidgetTest.Basic in ash_unittests

Review-Url: https://codereview.chromium.org/2807693002
Cr-Commit-Position: refs/heads/master@{#465918}

[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/BUILD.gn
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/date/tray_system_info.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/date/tray_system_info.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/network/tray_vpn.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/network/tray_vpn.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/palette/palette_tray.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/session/logout_button_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/session/logout_button_tray.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/status_area_widget.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/status_area_widget.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/status_area_widget_delegate.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/system_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/system_tray.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/system_tray_item.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/system_tray_item.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/tray_background_view.h
[add] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/tray_container.cc
[add] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/tray_container.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/tray/tray_item_view.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/user/tray_user.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/user/tray_user.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/e6704a0c2b29585fab489399ba0396104cff7d85/ash/system/web_notification/web_notification_tray.h

Labels: -M-59 M-60

Comment 5 by moh...@chromium.org, Apr 20 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment