New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698128 link

Starred by 10 users
Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
█ dominicc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651752



Sign in to add a comment

DOMParser.parseFromString() should propagate document's URL

Project Member Reported by tkent@chromium.org, Mar 3 2017 
What steps will reproduce the problem?
(1) Open http://w3c-test.org/domparsing/DOMParser-parseFromString-html.html

What is the expected result?
No FAILs

What happens instead?
FAILs for URL and baseURI.

Please use labels and text to provide additional information.

https://www.w3.org/TR/2016/WD-DOM-Parsing-20160517/#widl-DOMParser-parseFromString-Document-DOMString-str-SupportedType-type

> Additionally, the document must have a URL value equal to the URL of the active document, ...

Comment 1 by martin@martinrogalla.com, Mar 5 2017 

As this was unassigned, I decided to have a go at it. This is my first attempt at contributing to Chromium, so please double check that everything is up to your standards.

https://codereview.chromium.org/2732863002

Comment 2 by tkent@chromium.org, Mar 5 2017

Status: Started (was: Available)
martin@, thank you for woking on this issue.
- Please 'Publish' the code review.  Without it, we can't add review comments.
- You don't need to add new test. We already have the following failing tests, and the CL needs to update their test result.
  - external/wpt/domparsing/DOMParser-parseFromString-xml.html
  - external/wpt/domparsing/DOMParser-parseFromString-html.html

Comment 3 by tkent@chromium.org, Mar 8 2017

Labels: M-59
Status: Fixed (was: Started)
https://chromium.googlesource.com/chromium/src/+/c87999ea945e86d70cc5f98df81d65efc567cdd5 fixed this.

Comment 4 by tkent@chromium.org, Mar 21 2017

Cc: dominicc@chromium.org
 Issue 291791  has been merged into this issue.

Comment 5 by woxxom@gmail.com, Apr 18 2017 

I think the same/similar fix should be applied to DocumentFragment at least if it's .content inside <template> element: https://jsfiddle.net/c689LL32/ fails in Chrome, works in Firefox.

Comment 6 by tkent@chromium.org, Apr 18 2017 

#5, I don't think it's related to this issue.  Would you file new bug please?

Comment 7 by woxxom@gmail.com, Apr 19 2017 

tkent@, sure:  issue 713012 .
►

Sign in to add a comment