New issue
Advanced search Search tips

Issue 698125 link

Starred by 2 users
Status: Fixed
Owner:
caseq@chromium.org
Closed: May 2017
Cc:
pfeldman@chromium.org
alph@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools Timeline: NPE when collapsing last group that has selection

Project Member Reported by caseq@chromium.org, Mar 3 2017 
Chrome Version: ToT (0e430dc72813ba8fb8086228ab1032863381f582)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Open DevTools
(2) Switch to Timeline
(3) Make a recording
(4) Scroll to last group (typically GPU)
(5) Expand
(6) Select an event there
(7) Collapse

Observe the following exception in console:

Uncaught TypeError: Cannot read property 'startLevel' of undefined
    at PerfUI.FlameChart._toggleGroupVisibility (chrome-devtools://devtools/bundled/perf_ui/FlameChart.js:356)
    at PerfUI.FlameChart._onClick (chrome-devtools://devtools/bundled/perf_ui/FlameChart.js:330)

Comment 1 by caseq@chromium.org, Mar 3 2017

Components: Platform>DevTools>Performance
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b24a72f48297bc66d3e5c67f718f7d6797b4a5c

commit 6b24a72f48297bc66d3e5c67f718f7d6797b4a5c
Author: caseq <caseq@chromium.org>
Date: Fri Mar 03 07:50:43 2017

DevTools Timeline: fix NPE when collapsing the last group

... when selection is within the group.

BUG= 698125 

Review-Url: https://codereview.chromium.org/2722983007
Cr-Commit-Position: refs/heads/master@{#454540}

[modify] https://crrev.com/6b24a72f48297bc66d3e5c67f718f7d6797b4a5c/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Comment 3 by caseq@chromium.org, May 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment