Repeated entries in download referrer chain |
||||||||||
Issue descriptionPing examples: http://castor/szbjiczf85 http://castor/efl5t1j2l9 Simple fix: We only record navigations whose source and destination are different.
,
Mar 3 2017
,
Mar 3 2017
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a5231e4ca6ec1af9908e4b35590da1cdf4918fa commit 0a5231e4ca6ec1af9908e4b35590da1cdf4918fa Author: jialiul <jialiul@chromium.org> Date: Fri Mar 03 20:12:08 2017 Skip page refresh navigation in navigation observer Since page refresh navigations have the same source and destination url, and do not help us attribute downloads, we can safely skip them (and save the quota for other meaningful navigations). BUG= 698121 Review-Url: https://codereview.chromium.org/2728123003 Cr-Commit-Position: refs/heads/master@{#454658} [modify] https://crrev.com/0a5231e4ca6ec1af9908e4b35590da1cdf4918fa/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
,
Mar 3 2017
,
Mar 3 2017
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 3 2017
We're VERY close to M57 stable promotion for Desktop (RC cut on Monday, 03/06 @ 5:00 PM PT) so we're taking only important and critical merges in. CL listed at #4 is not baked in Canary yet. Can this wait until M58 or please provide justification for M57 merge. Thank you.
,
Mar 3 2017
This is a bug fixing for crbug.com/639467 which goes to M57. I'm OK with M58, or later M57 stable refresh.
,
Mar 5 2017
Landed in canary for 2 days, no change in performance, stability, and latency. @govind, request merge to M57 stable. Thanks!
,
Mar 6 2017
Approving merge to M57 branch 2987 based on comment #9. Please merge before 5:00 PM PT tomorrow, Monday (03/06) so we can take it in for Desktop stable cut. Thank you. This will also require a merge to M58. Please request a merge to M58.
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9336d16c03b81831b6e547a005a3dfd06b65450 commit f9336d16c03b81831b6e547a005a3dfd06b65450 Author: Jialiu Lin <jialiul@chromium.org> Date: Mon Mar 06 18:45:33 2017 Skip page refresh navigation in navigation observer Since page refresh navigations have the same source and destination url, and do not help us attribute downloads, we can safely skip them (and save the quota for other meaningful navigations). BUG= 698121 Review-Url: https://codereview.chromium.org/2728123003 Cr-Commit-Position: refs/heads/master@{#454658} (cherry picked from commit 0a5231e4ca6ec1af9908e4b35590da1cdf4918fa) Review-Url: https://codereview.chromium.org/2734913002 . Cr-Commit-Position: refs/branch-heads/2987@{#771} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/f9336d16c03b81831b6e547a005a3dfd06b65450/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc
,
Mar 6 2017
,
Mar 7 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725453932952d77108b603e1f66cf857051b69a3 commit 725453932952d77108b603e1f66cf857051b69a3 Author: Jialiu Lin <jialiul@chromium.org> Date: Tue Mar 07 19:16:03 2017 Skip page refresh navigation in navigation observer Since page refresh navigations have the same source and destination url, and do not help us attribute downloads, we can safely skip them (and save the quota for other meaningful navigations). BUG= 698121 Review-Url: https://codereview.chromium.org/2728123003 Cr-Commit-Position: refs/heads/master@{#454658} (cherry picked from commit 0a5231e4ca6ec1af9908e4b35590da1cdf4918fa) Review-Url: https://codereview.chromium.org/2731283005 . Cr-Commit-Position: refs/branch-heads/3029@{#48} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/725453932952d77108b603e1f66cf857051b69a3/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by jialiul@chromium.org
, Mar 3 2017