New issue
Advanced search Search tips

Issue 698109 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) in CrSettingsInternetPageTest.InternetPageTest

Project Member Reported by wkorman@chromium.org, Mar 3 2017

Issue description

Saw this on Sheriff-o-matic, filing bug to track work:

browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29


First failing build: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/23074

Failure snippet from log below. This looks like failing test:

https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cr_settings_browsertest.js?type=cs&q=CrSettingsInternetPageTest&sq=package:chromium&l=910

though I don't see any changes made today or yesterday to that file.

Passing to stevenjb@ to see if he can help us route or identify cause as he has done work here recently.

[25370:25370:0302/140146.798692:ERROR:CONSOLE(48)] "Mocha test failed: Internet SubPage VPN
AssertionError: expected false to be true
    at Function.assert.isTrue (chai.js:2423:31)
    at assertTrue (test_api.js:854:17)
    at Context.<anonymous> (internet_page_tests.js:171:7)
", source: mocha_adapter.js (48)
[25370:25370:0302/140147.146007:INFO:CONSOLE(125)] "Page load time: 5057 ms", source: polymer_browser_test_base.js (125)
[25370:25370:0302/140147.147608:INFO:CONSOLE(127)] "Test run time: 4209 ms", source: polymer_browser_test_base.js (127)
[25370:25370:0302/140147.149159:INFO:CONSOLE(129)] "Total time: 9267 ms", source: polymer_browser_test_base.js (129)
[25370:25370:0302/140147.149558:ERROR:web_ui_test_handler.cc(76)] Test Errors: 1/5 tests had failed assertions.
[25370:25370:0302/140147.150189:ERROR:web_ui_browser_test.cc(463)] CONDITION FAILURE: encountered javascript console error(s):
[25370:25370:0302/140147.150241:ERROR:web_ui_browser_test.cc(465)] JS ERROR: '[25370:25370:0302/140146.798692:ERROR:CONSOLE(48)] "Mocha test failed: Internet SubPage VPN
AssertionError: expected false to be true
    at Function.assert.isTrue (chai.js:2423:31)
    at assertTrue (test_api.js:854:17)
    at Context.<anonymous> (internet_page_tests.js:171:7)
", source: mocha_adapter.js (48)
'
[25370:25370:0302/140147.150285:ERROR:web_ui_browser_test.cc(467)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc:1291: Failure
Value of: RunJavascriptTestF( true, "CrSettingsInternetPageTest", "InternetPageTest")
  Actual: false
Expected: true
[25370:25370:0302/140148.023065:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[25370:25370:0302/140148.041296:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread.
[  FAILED  ] CrSettingsInternetPageTest.InternetPageTest, where TypeParam =  and GetParam() =  (17763 ms)
 
Cc: michae...@chromium.org
Cc: afakhry@chromium.org
Status: Started (was: Assigned)
Looking at the builder history this test appears to be flaky since it was introduced here:

https://codereview.chromium.org/2720503006

I will fix or disable the test.

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae62c32ff5a0da751cf186a97a9d2f2ff4552d6d

commit ae62c32ff5a0da751cf186a97a9d2f2ff4552d6d
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Mar 03 22:33:44 2017

InternetPageTest: flush dom after interactions

MockInteractions does not flush the DOM, so even though we call
testing.Test.disableAnimationsAndTransitions() in suiteSetup,
the subpage may not be populated immediately after a tap event.

BUG= 698109 

Review-Url: https://codereview.chromium.org/2727643010
Cr-Commit-Position: refs/heads/master@{#454691}

[modify] https://crrev.com/ae62c32ff5a0da751cf186a97a9d2f2ff4552d6d/chrome/test/data/webui/settings/internet_page_tests.js

Status: Fixed (was: Started)
This is fixed now.
Status: Assigned (was: Fixed)
Looks like there are still issues:

https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29
Preparing CL to disable on CrOS
Recent failures are a different issue, they are in"


DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_InterruptedResume

Please close this and open a new issue.

Summary: browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) in CrSettingsInternetPageTest.InternetPageTest (was: browser_tests failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1))
Renaming this to reduce confusion.

Status: Fixed (was: Assigned)

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment