New issue
Advanced search Search tips

Issue 698106 link

Starred by 2 users
Status: Fixed
Owner:
caseq@chromium.org
Closed: May 2017
Cc:
pfeldman@chromium.org
alph@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

DevTools: NPE upon hover over rail phases in Timeline

Project Member Reported by caseq@chromium.org, Mar 3 2017 
Chrome Version: ToT (0e430dc72813ba8fb8086228ab1032863381f582)

What steps will reproduce the problem?
(1) Open DevTools
(2) Switch to Timeline
(3) Record a timeline
(4) Hover over the name of the animation in "Interactions" strip
(5) Observe the following exception in console:

Uncaught TypeError: Cannot create property 'Symbol(timelineData)' on string 'Animation'
    at Function.forEvent (TimelineModel.js:1805)
    at Timeline.TimelineFlameChartDataProvider.highlightEntry (TimelineFlameChart.js:506)
    at PerfUI.FlameChart.highlightEntry (FlameChart.js:168)
    at PerfUI.FlameChart._updateHighlight (FlameChart.js:269)
    at PerfUI.FlameChart._onMouseMove (FlameChart.js:250)

This was regressed by https://codereview.chromium.org/2713363002

Comment 1 by caseq@chromium.org, Mar 3 2017

Components: Platform>DevTools>Performance
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c9e50b3b25885f6e7c638a7edab2a0c731c46a8

commit 6c9e50b3b25885f6e7c638a7edab2a0c731c46a8
Author: caseq <caseq@chromium.org>
Date: Fri Mar 03 03:26:51 2017

Timeline: fix NPE when hovering over Interactions strip

BUG= 698106 

Review-Url: https://codereview.chromium.org/2727583006
Cr-Commit-Position: refs/heads/master@{#454502}

[modify] https://crrev.com/6c9e50b3b25885f6e7c638a7edab2a0c731c46a8/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Comment 3 by caseq@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment