New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698105 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cleanup: delete chromiumos-build-stats code and callers

Project Member Reported by akes...@chromium.org, Mar 3 2017

Issue description

Forked from email thread, motivated by pending gce filewall rules enforcer rendering this project obsolete.
 
The relevant code is in chromite, lib/stats.py, plus all its callers.
Should also probably shut down the matching AppEngine and delete the years of data stored in it.

https://chromiumos-build-stats.appspot.com/
Owner: akes...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/65b7c2567c2c37cedb86bac96f81316ff06ae3f0

commit 65b7c2567c2c37cedb86bac96f81316ff06ae3f0
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed Mar 08 02:07:30 2017

do not call upload_command_stats

BUG= chromium:698105 
TEST=None

Change-Id: Ieb29ea6ad326c7050c002cccec35c94450dbcfae
Reviewed-on: https://chromium-review.googlesource.com/450846
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/65b7c2567c2c37cedb86bac96f81316ff06ae3f0/common.sh

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/65b7c2567c2c37cedb86bac96f81316ff06ae3f0

commit 65b7c2567c2c37cedb86bac96f81316ff06ae3f0
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed Mar 08 02:07:30 2017

do not call upload_command_stats

BUG= chromium:698105 
TEST=None

Change-Id: Ieb29ea6ad326c7050c002cccec35c94450dbcfae
Reviewed-on: https://chromium-review.googlesource.com/450846
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/65b7c2567c2c37cedb86bac96f81316ff06ae3f0/common.sh

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/01a82e99d39320bb3b03cf1476dd617d22b1470b

commit 01a82e99d39320bb3b03cf1476dd617d22b1470b
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed Mar 08 02:07:30 2017

delete chromiumos-build-stats code and callers

CQ-DEPEND=CL:450846
BUG= chromium:698105 
TEST=None
Change-Id: Ib0d2c10b35873eb768bd98f8946380ea7939012a
Reviewed-on: https://chromium-review.googlesource.com/449018
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/appengine/ae_pylint
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_clean.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/app.yaml
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/index.yaml
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/scripts/cros_unittest.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/stylesheets/main.css
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_chrome_sdk.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/index.html
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/scripts/deploy_chrome_unittest.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_chroot.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/main.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/stats.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/command.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_shell.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/scripts/upload_command_stats_unittest.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_debug.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/appengine/README
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_deploy.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/bin/upload_command_stats
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/scripts/deploy_chrome.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/scripts/upload_command_stats.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/appengine/chromiumos-build-stats/model.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/scripts/cros.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/scripts/upload_command_stats_unittest
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/lib/stats.py
[modify] https://crrev.com/01a82e99d39320bb3b03cf1476dd617d22b1470b/cli/cros/cros_flash.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/lib/stats_unittest.py
[delete] https://crrev.com/e30397d83d7bf84734c00e9776ef703f75d44d23/lib/stats_unittest

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment